Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix the calendar exception to handle null#19691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fix the calendar exception to handle null, error was raised while exporting from akeneoThe Symfony\Component\Intl\DateFormatter\IntlDateFormatter::__construct() method's argument $calendar value NULL behavior is not implemented. Only the GREGORIAN calendar is supported. Please install the "intl" extension for full localization capabilities.https://cloud.githubusercontent.com/assets/4486133/17287404/81f951cc-57e0-11e6-9f6f-e231bbf00bf4.png
jameshalsall commentedAug 21, 2016
This PR should be targeted at 2.7 branch. |
| * | ||
| * @throws MethodArgumentValueNotImplementedException When $locale different than "en" or null is passed | ||
| * @throws MethodArgumentValueNotImplementedException When $calendar different than GREGORIAN is passed | ||
| * @throws MethodArgumentValueNotImplementedException When $calendar different than GREGORIAN is passed or null is passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change is wrong (no exception will be thrown when null is passed).
The docblock that needs to be changed is the@param above.
nicolas-grekas commentedAug 22, 2016
@wakqasahmed can you please add a test case? And ideally rebase on 2.7 also? (and change the base branch here on github as a consequence?) |
wakqasahmed commentedAug 26, 2016
Submitted new PR (#19751) targeting branch 2.7 and having test case. Closing this one. |
Fix the calendar exception to handle null, error was raised while exporting from akeneo
The Symfony\Component\Intl\DateFormatter\IntlDateFormatter::__construct() method's argument $calendar value NULL behavior is not implemented. Only the GREGORIAN calendar is supported. Please install the "intl" extension for full localization capabilities.
https://cloud.githubusercontent.com/assets/4486133/17287404/81f951cc-57e0-11e6-9f6f-e231bbf00bf4.png