Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Disable CLI color for Windows 10 greater than 10.0.10586#19660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * Colorization is disabled if not supported by the stream: | ||
| * | ||
| * - Windowsbefore 10.0.10586 without Ansicon, ConEmu or Mintty | ||
| * - Windowsnot 10.0.10586 without Ansicon, ConEmu or Mintty |
nicolas-grekasAug 18, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what about: Windows!= 10.0.10586 without Ansicon, ConEmunor Mintty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Well, for me!= andnot are synonymous...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
for me!= means "different than", which reads better imho than "not"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since for you it's so relevant, I updated this PR 😉
nicolas-grekas commentedAug 19, 2016
👍 |
nicolas-grekas commentedAug 19, 2016
Thank you@mlocati. |
…mlocati)This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes#19660).Discussion----------Disable CLI color for Windows 10 greater than 10.0.10586| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19520| License | MIT| Doc PR |The command prompt in Windows 10.0.10586 had enabled color support by default.But in the next Windows versions they disabled it ([reference](https://wpdev.uservoice.com/forums/266908-command-prompt-console-bash-on-ubuntu-on-windo/suggestions/15617610--re-enable-enable-virtual-terminal-processing-by)): every exe now needs to explicitly turn on the color support.I [already asked](https://bugs.php.net/bug.php?id=72768) the PHP dev team to enable it for php.exe, but they said they are busy for now.So, let's turn off colors for Windows, until we'll have new PHP versions with color support enabled.Commits-------255c59f Disable CLI color for Windows 10 greater than 10.0.10586
The command prompt in Windows 10.0.10586 had enabled color support by default.
But in the next Windows versions they disabled it (reference): every exe now needs to explicitly turn on the color support.
Ialready asked the PHP dev team to enable it for php.exe, but they said they are busy for now.
So, let's turn off colors for Windows, until we'll have new PHP versions with color support enabled.