Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[POC] [VarDumper] Added StringDumper to export dump as string#19616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@wouterj
Copy link
Member

@wouterjwouterj commentedAug 14, 2016
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#18149
LicenseMIT
Doc PRtodo

This allows to export dumps as a string, instead of having it dumped to a stream. This is usefull when using the VarDumper as var exporter (e.g. in#19614 & see referenced issue).

Todo

  • Fix TwigBridge usage

@wouterjwouterj changed the title[VarDumper] Added StringDumper to export dump as string[POC] [VarDumper] Added StringDumper to export dump as stringAug 14, 2016
$this->dumper =$dumper ?:newHtmlDumper();

if (null ===$dumper || !$dumperinstanceof ToStringDumper) {
$this->dumper =newToStringDumper(newHtmlDumper());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we wrap passed dumper instead of silent replace it?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yep, that's a typo

@nicolas-grekas
Copy link
Member

I'm rather 👎 here. It hides how things work (for a reason). I submitted#19624 instead, to make getting a string simpler.
I also target#17290 as a more generic approach to make getting & customizing dumps easier.

@wouterjwouterj deleted the var-dumper/string-dumper branchAugust 19, 2016 08:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wouterj@nicolas-grekas@Koc@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp