NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Config] Allow validating values using callables in ExprBuilder#19578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

chalasr wants to merge1 commit intosymfony:masterfromchalasr:expr_builder_callable

Closed

[Config] Allow validating values using callables in ExprBuilder#19578

chalasr wants to merge1 commit intosymfony:masterfromchalasr:expr_builder_callable

Conversation

Copy link

Member

chalasr commentedAug 9, 2016

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

This PR is a proposal for adding the ability to pass any callable for validating values using the ExprBuilder, which accepts only closures ATM.

The problem with closures is they often involve to write redundant code such as useless assignments or intermediate methods or lots of arguments in theuse() part of the closure, as soon as the validation logic is decoupled from the configuration for instance.

Before

publicfunctiongetConfigTreeBuilder(){// ...$validator =$this->validator;$rootNode        ->children()            ->scalarNode('foo')                ->validate()                ->ifString()                    ->then(function ($v)use ($validator) {return$validator->validate($v); })                ->end()            ->end()        ->end()    ->end()}

After

// ...$rootNode        ->children()            ->scalarNode('foo')                ->validate()                ->ifString()                    ->then([$this->validator,'validate'])                ->end()            ->end()        ->end()    ->end()

It is a BC break but IMHO it worths it, ATM I don't see any use case where this would have a negative impact, except when overriding the changed methods (never saw such case).

Allow validating values using callable

773b4df

carsonbot added Status: Needs Review Config Feature BC Break labels

Aug 9, 2016

Copy link

Member

nicolas-grekas commentedAug 9, 2016•
edited
Loading

As you spotted, it's a BC break, forbidden by our written policy.
Btw, on PHP 7.1, you could write:
->then(\Closure::fromCallable([$this->validator, 'validate'])) :)
and on PHP 5.4 you can already write:
->then(function ($v) {return $this->validator->validate($v);})

👎