Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config] Fix YamlReferenceDumper prototyped array support#19570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Config] Fix YamlReferenceDumper prototyped array support#19570
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| "symfony/filesystem":"~2.3" | ||
| }, | ||
| "require-dev": { | ||
| "symfony/yaml":"~2.7|~3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this the proper versions constraint to use ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should be ~2.7 on 2.7,
~2.8|~3.0.0 on 2.8
and ~2.8|~3.0 on 3.1
should be done while merging up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you@nicolas-grekas . I'll update the PR.
| boolean: true | ||
| scalar_empty: ~ | ||
| scalar_null:~ | ||
| scalar_null:null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why is it dumped asnull here while all other places using null are dumping it as~ ?
ogizanagiAug 23, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because theExampleConfiguration explicitly sets the default value tonull.
When setting a default value,theYamlReferenceDumper will replace the default~ by this value :)
(This is not related to the changes in this PR, though)
ogizanagi commentedSep 13, 2016
Any update about this one ? Should it rather be considered as a new feature as this implementation is missing since the introduction of the yaml dumper ? |
fabpot commentedSep 13, 2016
As the test is marked as skipped by mentioning specifically that this is not supported, I would say that this is indeed a new feature that needs to be merged in master. |
fabpot commentedSep 13, 2016
Can you update the PR accordingly? Thanks. |
ogizanagi commentedSep 14, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
fabpot commentedSep 14, 2016
Thank you@ogizanagi. |
…ort (ogizanagi)This PR was merged into the 3.2-dev branch.Discussion----------[Config] Fix YamlReferenceDumper prototyped array support| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Also related to#19480 which fixes another prototype issue, but cannot be tested properly on Travis because marked as skipped by this missing implementation.Previous output was:```yaml [...] parameters: # Prototype name: ~ connections: user: ~ pass: ~```instead of:```yaml [...] parameters: # Prototype name: ~ connections: # Prototype - user: ~ pass: ~```Commits-------063a980 [Config] Fix YamlReferenceDumper prototyped array support
…otypes (ogizanagi)This PR was merged into the 3.2-dev branch.Discussion----------[Config] Fix (Yaml|Xml)ReferenceDumper for nested prototypes| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This tries to fix the nested prototypes case for the `YamlReferenceDumper` and `XmlReferenceDumper`.### Before```ymlcms_pages: # Prototype page: []```### After```ymlcms_pages: # Prototype page: # Prototype locale: title: ~ # Required path: ~ # Required```~~However, the `YamlReferenceDumperTest::testDumper` is marked as skipped, due to another unsupported prototype usage, but that's another issue (the `connections` key). Thus, the bug fix must be tested manually :/ (I'd recommend to merge#19570 first)~~Commits-------1e80510 [Config] Fix YamlReferenceDumper for nested prototypes
Uh oh!
There was an error while loading.Please reload this page.
Also related to#19480 which fixes another prototype issue, but cannot be tested properly on Travis because marked as skipped by this missing implementation.
Previous output was:
instead of: