Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix #19531 [Form] DateType fails parsing when midnight is not a valid time#19541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mbeccati commentedAug 5, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19531 |
| License | MIT |
| Doc PR |
Jean85 commentedAug 5, 2016
Thanks for fixing this so fast! Status: reviewed |
| */ | ||
| protectedfunctionisPatternDateOnly() | ||
| { | ||
| // the default pattern includes time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe this comment is unnecessary?
mbeccati commentedAug 5, 2016
@javiereguiluz Pushed comment amendments + additional test w/ escaped text |
| } | ||
| // strip escaped text | ||
| $pattern =preg_replace("#'(.*?)'#",'',$this->pattern); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you add a test with escaped ICU data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oh, it's there, I had to right scroll :)
nicolas-grekas commentedAug 9, 2016
👍 |
fabpot commentedAug 13, 2016
Thank you@mbeccati. |
…not a valid time (mbeccati)This PR was merged into the 2.7 branch.Discussion----------Fix#19531 [Form] DateType fails parsing when midnight is not a valid time| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19531| License | MIT| Doc PR |Commits-------c951bb6Fix#19531 [Form] DateType fails parsing when midnight is not a valid time
…sformer (mbeccati)This PR was merged into the 2.7 branch.Discussion----------[Form] Incorrect timezone with DateTimeLocalizedStringTransformer| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19721| License | MIT| Doc PR | n.a.Issue was introduced in#19541Commits-------bf6691cFix#19721