Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[master][console] Allow multiple options to be set.#19495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedJul 31, 2016
Anything not related to this new feature should be removed as it would make merging old branches more difficult (and they don't bring any value anyway). |
| /** | ||
| * @group legacy | ||
| * @dataProvider provideInlineStyleTagsWithUnknownOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missing@requires function Symfony\Bridge\PhpUnit\ErrorAssert::assertDeprecationsAreTriggered annotation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done,
just for my understanding, why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@SpacePossum when tests run in max depth (latest versions of the components supported for an older package) this function might not be available from the bridge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
make sense, thanks for the info@HeahDude !
11649ef to243d6fcCompare4cee435 to1430138CompareSpacePossum commentedAug 29, 2016
rebased and all comments addressed |
fabpot commentedSep 14, 2016
Thank you@SpacePossum. |
…pacePossum)This PR was merged into the 3.2-dev branch.Discussion----------[master][console] Allow multiple options to be set.| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| License | MITThis PR add the possibility to set multiple options on a formatted string output.Example:```php$output->writeln('<fg=green;options=bold,underscore>Test</>');```Secondly it makes the behavior on invalid values consistent.```php// current$output->writeln('<fg=lime;>Test</>'); // throws exception$output->writeln('<options=italic;>Test</>'); // silent ignore// new$output->writeln('<fg=lime;>Test</>'); // throws exception$output->writeln('<options=italic;>Test</>'); // throws exception```All other changes are about making the code more strict or other SCA/CS fixes.Commits-------1430138 Allow multiple options to be set.…SpacePossum)This PR was merged into the master branch.Discussion----------[Console] Add multiple options for the output exampleWithsymfony/symfony#19495 merged to master a way to set multiple options has been added.Commits-------c6b4738 Update coloring.rst
This PR add the possibility to set multiple options on a formatted string output.
Example:
Secondly it makes the behavior on invalid values consistent.
All other changes are about making the code more strict or other SCA/CS fixes.