Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Fix abstract AdapterTestCase cache property#19474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedJul 29, 2016
Thank you@tgalopin. |
nicolas-grekas added a commit that referenced this pull requestJul 29, 2016
…lopin)This PR was submitted for the master branch but it was merged into the 3.1 branch instead (closes#19474).Discussion----------[Cache] Fix abstract AdapterTestCase cache property| Q | A| ------------- | ---| Branch? | master| Bug fix? | Sort of| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | reference to the documentation PR, if anyThe `AdapterTestCase` extends the `CachePoolTest` from the [cache/integration-tests package](https://packagist.org/packages/cache/integration-tests) in order to test cache pools but it tries to reuse a private variable from its parent class.As there is no need to use a property in this case, I simply replace the variable by a local one.Commits-------348b335 [Cache] Fix abstract AdapterTestCase cache property
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AdapterTestCaseextends theCachePoolTestfrom thecache/integration-tests package in order to test cache pools but it tries to reuse a private variable from its parent class.As there is no need to use a property in this case, I simply replace the variable by a local one.