Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Yaml] require space after colon after mapping key#19472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
xabbuh wants to merge3,273 commits intosymfony:2.7fromxabbuh:issue-19436

Conversation

@xabbuh
Copy link
Member

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#19436
LicenseMIT
Doc PR

HeahDudeand others added30 commitsJune 23, 2016 15:44
…(HeahDude)This PR was merged into the 3.2-dev branch.Discussion----------[Yaml] Added support for parsing PHP constants| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | ~| License       | MIT| Doc PR        | TODOCommits-------17ec26e [DI] added support for PHP constants in yaml configuration files02d1dea [Yaml] added support for parsing PHP constants
…ick)This PR was merged into the 3.2-dev branch.Discussion----------[FrameworkBundle] Remove redundant code| Q             | A| ------------- | ---| Branch?       | "master"| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Was part ofsymfony#17706.Change the remaining ``isset($config['foo'])`` to ``$this->isConfigEnabled($config['foo'])`` to allow to use parameters to enable a feature.Commits-------a21af88 [FrameworkBundle] Remove redundant code
…l < 3.1 (HeahDude)This PR was merged into the 3.1 branch.Discussion----------[WebProfilerBundle] Added a conflict for Http-Kernel < 3.1| Q             | A| ------------- | ---| Branch?       | 3.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |silexphp/Silex-WebProfiler#94| License       | MIT| Doc PR        | ~Commits-------d3f47f7 updated Http-Kernel dependency
…vate (xabbuh)This PR was merged into the 3.2-dev branch.Discussion----------[Console] LockableTrait: change visibility to private| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |symfony#18471 (comment)| License       | MIT| Doc PR        |Without this change we force users to expose unnecessary extension points they may not want to provide.Commits-------eaa3bb0 LockableTrait: change visibility to private
…(xabbuh)This PR was merged into the 3.2-dev branch.Discussion----------[Console] update the author of the LockableTrait| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |symfony#18471 (comment)| License       | MIT| Doc PR        |Commits-------b15fec7 update the author of the LockableTrait
This PR was merged into the 3.2-dev branch.Discussion----------Undefined variable $name| Q             | A| ------------- | ---| Branch?       | "master" for new features / 2.7, 2.8, 3.0 or 3.1 for fixes| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MITCommits-------8304bcc Undefined variable $name
Remove input/output from method arguments, use SymfonyStyle insteadAvoid 'error in filename' if no filename as argumentAdd missing array typehint to files argument of display*() methodsStore format option as member rather than pass it in method callsCS fixes
…lay options (MGDSoft, nicolas-grekas)This PR was merged into the 3.2-dev branch.Discussion----------[VarDumper] Add maxDepth & maxStringLength display options| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |symfony#16741| License       | MIT| Doc PR        | -Takes oversymfony#18148 to add display options to html dumps.Status: needs workCommits-------998ff33 [VarDumper] Tweak display options implementation58eb665 [VarDumper] Add maxDepth & maxStringLength display options
…nicolas-grekas)This PR was merged into the 3.2-dev branch.Discussion----------[VarDumper] Allow full collapsing of HTML dumps| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |symfony#16741| License       | MIT| Doc PR        | -Because I missed the feature request insymfony#16741 to allow full collapsing.Commits-------633989b [VarDumper] Allow full collapsing of HTML dumps
…y on PHP 7.0 (tgalopin)This PR was merged into the 3.2-dev branch.Discussion----------[Cache] Add PhpArrayAdapter to use shared memory on PHP 7.0| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | WIP| Fixed tickets | -| License       | MIT| Doc PR        | -Depends onsymfony#18825This PR aims to implement a Symfony Cache adapter able to build files optimized for OPCache memory storage. Any kind of static data that can be warmed up is a candidate for OPcache storage.This PR is limited to the implementation of the Adapter. It's usage in the annotations caching system is implemented in the PRsymfony#18533. The aim is also to use this adapter in other contexts (validator, serializer, ...).Commits-------28a40d2 [Cache] Add PhpArrayAdapter to use shared memory on PHP 7.0+
* 2.7:  [CS] Respect PSR2 4.2  [Form] fix `empty_data` option in expanded `ChoiceType`  [Console] removed unneeded private methods  sync min email validator version  [TwigBridge] Fix inconsistency in LintCommand help  explicitly forbid e-mail validator 2.0 or higher  Fixed SymfonyQuestionHelper multi-choice with defaults  [DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure  Differentiate between the first time a progress bar is displayed and subsequent times  finished previous commit  No more exception for malformed input name  fix post_max_size_message translation  [Process] Fix pipes cleaning on Windows  Avoid phpunit 5.4 warnings on getMock  [Form] Add exception to FormRenderer about non-unique block names  [Form] Consider a violation even if the form is not submitted
* 2.8:  [CS] Respect PSR2 4.2  [Form] fix `empty_data` option in expanded `ChoiceType`  [Console] removed unneeded private methods  [Security] [Guard] Improve comment with working example  sync min email validator version  [TwigBridge] Fix inconsistency in LintCommand help  explicitly forbid e-mail validator 2.0 or higher  Fixed SymfonyQuestionHelper multi-choice with defaults  [DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure  Differentiate between the first time a progress bar is displayed and subsequent times  finished previous commit  No more exception for malformed input name  fix post_max_size_message translation  [Process] Fix pipes cleaning on Windows  Avoid phpunit 5.4 warnings on getMock  [Form] Add exception to FormRenderer about non-unique block names  [Form] Consider a violation even if the form is not submitted
* 3.0:  [CS] Respect PSR2 4.2  [Form] fix `empty_data` option in expanded `ChoiceType`  [Console] removed unneeded private methods  [Security] [Guard] Improve comment with working example  sync min email validator version  [TwigBridge] Fix inconsistency in LintCommand help  explicitly forbid e-mail validator 2.0 or higher  Fixed SymfonyQuestionHelper multi-choice with defaults  [DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure  Differentiate between the first time a progress bar is displayed and subsequent times  finished previous commit  No more exception for malformed input name  fix post_max_size_message translation  [Process] Fix pipes cleaning on Windows  Avoid phpunit 5.4 warnings on getMock  [Form] Add exception to FormRenderer about non-unique block names  [Form] Consider a violation even if the form is not submitted
* 3.1:  [CS] Respect PSR2 4.2  [Form] fix `empty_data` option in expanded `ChoiceType`  [Console] removed unneeded private methods  updated Http-Kernel dependency  [Security] [Guard] Improve comment with working example  sync min email validator version  [TwigBridge] Fix inconsistency in LintCommand help  explicitly forbid e-mail validator 2.0 or higher  Fixed SymfonyQuestionHelper multi-choice with defaults  [DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure  Differentiate between the first time a progress bar is displayed and subsequent times  finished previous commit  No more exception for malformed input name  fix post_max_size_message translation  [Process] Fix pipes cleaning on Windows  Avoid phpunit 5.4 warnings on getMock  [Form] Add exception to FormRenderer about non-unique block names  [FrameworkBundle] templating can be fully disabled  [Form] Consider a violation even if the form is not submitted
@nicolas-grekas
Copy link
Member

Should trigger a deprecation instead (thus on master?)

@fabpot
Copy link
Member

Why would you want to trigger a deprecation on a bug?

@nicolas-grekas
Copy link
Member

Because I'm sure some people out there have invalid Yaml file that are accepted by our parser, and we're going to break their app. This is a BC break to me, don't you think?

@fabpot
Copy link
Member

Fair enough, seeing that we also have tests that exhibit this wrong behavior, let's deprecate this on master first.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJul 29, 2016
edited
Loading

And I propose to go one step further and add a flag so that people can opt-in for the exception instead of the deprecation. I'm anticipating a need for this in blackfire where we'll want to disallow invalid yaml (because we want parsing parity with a strict go yaml parser).

ro0NLand others added14 commitsJuly 29, 2016 05:54
… formatting (ro0NL)This PR was squashed before being merged into the 3.2-dev branch (closessymfony#19275).Discussion----------[Console][FrameworkBundle] Revised console header formatting| Q             | A| ------------- | ---| Branch?       | "master"| Bug fix?      | no| New feature?  | yes (ui change)| BC breaks?    | no| Deprecations? | no| Tests pass?   | not yet| Fixed tickets |symfony#19095| License       | MIT| Doc PR        | reference to the documentation PR, if anyBefore/After![image](https://cloud.githubusercontent.com/assets/1047696/16983804/e36c95e0-4e76-11e6-854d-dfa22c634b39.png)Commits-------fcddb3a [Console][FrameworkBundle] Revised console header formatting
…ty (tgalopin)This PR was submitted for the master branch but it was merged into the 3.1 branch instead (closessymfony#19474).Discussion----------[Cache] Fix abstract AdapterTestCase cache property| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | Sort of| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | reference to the documentation PR, if anyThe `AdapterTestCase` extends the `CachePoolTest` from the [cache/integration-tests package](https://packagist.org/packages/cache/integration-tests) in order to test cache pools but it tries to reuse a private variable from its parent class.As there is no need to use a property in this case, I simply replace the variable by a local one.Commits-------348b335 [Cache] Fix abstract AdapterTestCase cache property
* 2.7:  Minor fixes  [Console] Overcomplete argument exception message tweak.
* 2.8:  Minor fixes  [Console] Overcomplete argument exception message tweak.  fixed bad auto merge  Console table cleanup  undefined offset fix (symfony#19406)  [EventDispatcher] Removed unused variable
* 3.0:  Minor fixes  [Console] Overcomplete argument exception message tweak.  fixed bad auto merge  Console table cleanup  undefined offset fix (symfony#19406)  [EventDispatcher] Removed unused variable
* 3.1:  Minor fixes  [Cache] Fix abstract AdapterTestCase cache property  [Console] Overcomplete argument exception message tweak.  fixed bad auto merge  Console table cleanup  undefined offset fix (symfony#19406)  [EventDispatcher] Removed unused variable
…od (tgalopin)This PR was merged into the 3.2-dev branch.Discussion----------[Filesystem] Add a cross-platform readlink method| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -`readlink()` and `realpath()` have a completely different behavior under Windows and Unix:- `realpath()` resolves recursively the children links of a link until a final target is found on Unix and resolves only the next link on Windows ;- `readlink()` resolves recursively the children links of a link until a final target is found on Windows and resolves only the next link on Unix ;I propose to solve this by implementing a helper method in the Filesystem component that would behave always the same way under all platforms.Commits-------c36507e [Filesystem] Add a cross-platform readlink/realpath methods for nested links
…ew cache warmer for annotations (tgalopin)This PR was squashed before being merged into the 3.2-dev branch (closessymfony#18533).Discussion----------[FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | WIP| Fixed tickets | -| License       | MIT| Doc PR        | -Depends onsymfony#18825 andsymfony#18823This PR implements the usage of the new OpCacheAdapter in the annotations caching system. The idea to use this adapter as much as possible in Symfony (validator, serializer, ...). These other implementations will be the object of different PRs.Commits-------f950a2b [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations
…nd annotated classes to compile using patterns (tgalopin)This PR was merged into the 3.2-dev branch.Discussion----------[HttpKernel] Allow bundles to declare classes and annotated classes to compile using patterns| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -This PR introduces a simple system of patterns based on wildcards for classes to cache in the HttpKernel dependency injections extensions. This system started to be implemented insymfony#18533 but I split it up here to use it also in the classes to compile.Commits-------1be7424 [HttpKernel] Allow usage of patterns in classes and annotations to cache
@xabbuh
Copy link
MemberAuthor

closing in favour of#19504

@xabbuhxabbuh closed thisAug 2, 2016
fabpot added a commit that referenced this pull requestAug 2, 2016
… (xabbuh)This PR was merged into the 3.2-dev branch.Discussion----------[Yaml] deprecate missing space after mapping key colon| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#19436,#19472| License       | MIT| Doc PR        |Commits-------9a31eef deprecate missing space after mapping key colon
@xabbuhxabbuh deleted the issue-19436 branchAugust 2, 2016 10:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

28 participants

@xabbuh@nicolas-grekas@fabpot@carsonbot@HeahDude@GuilhemN@janczer@chalasr@MGDSoft@tgalopin@tucksaun@Tobion@ro0NL@voronkovich@javiereguiluz@Rootie@pasdeloup@remicollet@dunglas@theofidry@Koc@ogizanagi@antograssiot@SCIF@stof@jeremyFreeAgent@DavidBadura@ReenExe

[8]ページ先頭

©2009-2025 Movatter.jp