Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix PHP 7.1 related failures#19384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedJul 19, 2016
Do we need to add 7.1 to the travis matrix then? |
e27cdc2 tof8abf30Compare| }, | ||
| "require-dev": { | ||
| "symfony/yaml":"~2.1", | ||
| "symfony/yaml":"~2.3.42|~2.7.14|~2.8.7|~3.0.7|~3.1.1|~3.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
#18861 required on PHP 7.1
| }, | ||
| "require-dev": { | ||
| "symfony/yaml":"~2.1", | ||
| "symfony/yaml":"~2.3.42|~2.7.14|~2.8.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should be~2.8.7|~3.0.7|~3.1.1|~3.2 when merging in 3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
3.0.9 and 3.1.3, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
3.0.7&3.1.1 here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
See#18861
nicolas-grekas commentedJul 19, 2016
Green, with php7.1 included in the test matrix |
stof commentedJul 19, 2016
👍 |
fabpot commentedJul 19, 2016
Thank you@nicolas-grekas. |
This PR was merged into the 2.7 branch.Discussion----------Fix PHP 7.1 related failures| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -PHP 7.1 triggers notices on previously silent implicit type changes.Commits-------07467ed Fix PHP 7.1 related failures
PHP 7.1 triggers notices on previously silent implicit type changes.