Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Add Request::isMethodIdempotent method#19322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dunglas commentedJul 9, 2016
AppVeyor failures unrelated. |
| self::METHOD_PUT, | ||
| self::METHOD_DELETE, | ||
| self::METHOD_TRACE, | ||
| self::METHOD_OPTIONS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would use the strings here directly as done for theisMethodSafe method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi, why use strings instead of constants here?
dunglas commentedJul 10, 2016
Comments fixed. |
fabpot commentedJul 10, 2016
Thank you@dunglas. |
Addd a new method in the spirit of
isMethodSafeto know if the current method is idempotent according to RFCs.