Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] Use empty instead of count in RequestMatcher#19320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
dunglas wants to merge1 commit intosymfony:2.7fromdunglas:optim_request_matcher

Conversation

@dunglas
Copy link
Member

QA
Branch?2.7
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRn/a

Miro optimization...

@stloyd
Copy link
Contributor

-1 as this 'micro' optimization is so small that you never notice it in real life usage IMO.

@fabpot
Copy link
Member

I'm also -1 as the current expression is very clear on what we check for. The semantic ofempty is very blurry to say the least.

@dunglas
Copy link
MemberAuthor

Fair enough

@dunglasdunglas closed thisJul 9, 2016
@dunglasdunglas deleted the optim_request_matcher branchJuly 9, 2016 10:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dunglas@stloyd@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp