Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[BrowserKit] Update Client::getAbsoluteUri() for query string only URIs#19317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:2.7fromgeoraldc:support-get-absolute-query-string-only-urlJul 10, 2016
Merged
[BrowserKit] Update Client::getAbsoluteUri() for query string only URIs#19317
fabpot merged 1 commit intosymfony:2.7fromgeoraldc:support-get-absolute-query-string-only-urlJul 10, 2016
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Apply same rules to query string only URIs as what's being used for URIs containing only hash/anchor values
Member
nicolas-grekas commentedJul 10, 2016
👍 |
Member
fabpot commentedJul 10, 2016
Thank you@georaldc. |
fabpot added a commit that referenced this pull requestJul 10, 2016
…ing only URIs (georaldc)This PR was merged into the 2.7 branch.Discussion----------[BrowserKit] Update Client::getAbsoluteUri() for query string only URIs| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19303| License | MIT| Doc PR | -This PR allows BrowserKit to treat a value containing only query string parameters the same way anchor/hash values are treated when passed as a URI argument to the getAbsoluteUri() method. Helps when encountering sites that force a redirect with a location header value containing only a query string.Commits-------965408f Update getAbsoluteUri() for query string uris
| if (!$uri ||'#' ==$uri[0]) { | ||
| returnpreg_replace('/#.*?$/','',$currentUri).$uri; | ||
| // anchor or query string parameters? | ||
| if (!$uri ||'#' ==$uri[0] ||'?' ==$uri[0]) { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Those both checks should be strict (===).
This was referencedJul 30, 2016
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows BrowserKit to treat a value containing only query string parameters the same way anchor/hash values are treated when passed as a URI argument to the getAbsoluteUri() method. Helps when encountering sites that force a redirect with a location header value containing only a query string.