Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Yaml] fix parsing multi-line mapping values#19304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
xabbuh wants to merge1 commit intosymfony:2.7fromxabbuh:issue-11109

Conversation

@xabbuh
Copy link
Member

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#11109
LicenseMIT
Doc PR

@fabpot
Copy link
Member

The question is whether we want to support this. Having a string on multiple lines is already supported via '|' for instance, so do we really need another way? Wouldn't it be good to re-read the spec and write a doc that explicitly list what we do support and what we don't want to support?

@xabbuh
Copy link
MemberAuthor

I could also live with not fixing this issue. Though in that case I suggest to provide a more meaningful exception message (something like what I suggested in#11911).

@xabbuh
Copy link
MemberAuthor

ping @symfony/deciders Any opinion on this?

@Tobion
Copy link
Contributor

If that is according to the yaml spec, we should support it as well. We removed support for other stuff like non-quoted strings starting with% to increase compatibility. That wouldn't make sense if the full spec is not supported anyway.

dunglas reacted with thumbs up emoji

@fabpot
Copy link
Member

We don't want to support the full YAML spec but a subset of it. So, removing things that were not compatible with the YAML spec was needed but this is different from supporting features that are currently not supported.

@javiereguiluz
Copy link
Member

👍 because this YAML feature is not that "edgy" and because the implementation is reasonably small and simple.

Status: reviewed

@fabpot
Copy link
Member

ok, let's do it. But that's a new feature then, which should be done on master.@xabbuh I let you merge this on master (there are some conflicts).

@smarcet
Copy link

is there is any update of this fix ?
regards

@xabbuhxabbuh deleted the issue-11109 branchSeptember 20, 2016 08:35
@fabpotfabpot mentioned this pull requestOct 27, 2016
fabpot added a commit that referenced this pull requestMay 11, 2020
…inkine)This PR was merged into the 3.4 branch.Discussion----------[Yaml] Fix escaped quotes in quoted multi-line string| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| License       | MITThis PR continues#19304This PR fixes incorrect parsing quoted multi-line string which contain escaped quotes, see testsCommits-------2e99caa [Yaml] Fix escaped quotes in quoted multi-line string
symfony-splitter pushed a commit to symfony/yaml that referenced this pull requestMay 11, 2020
…inkine)This PR was merged into the 3.4 branch.Discussion----------[Yaml] Fix escaped quotes in quoted multi-line string| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| License       | MITThis PR continuessymfony/symfony#19304This PR fixes incorrect parsing quoted multi-line string which contain escaped quotes, see testsCommits-------2e99caacaf [Yaml] Fix escaped quotes in quoted multi-line string
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xabbuh@fabpot@Tobion@javiereguiluz@smarcet@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp