Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Clarify deprecation of non-scalar values in surrogate fragment renderer#19281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:3.1fromchalasr:surrogate_renderer_nonscalar_deprecationJul 4, 2016
Merged
[HttpKernel] Clarify deprecation of non-scalar values in surrogate fragment renderer#19281
fabpot merged 1 commit intosymfony:3.1fromchalasr:surrogate_renderer_nonscalar_deprecationJul 4, 2016
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
chalasr commentedJul 4, 2016
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19262 |
| License | MIT |
| Doc PR | ~ |
| if (!$this->surrogate || !$this->surrogate->hasSurrogateCapability($request)) { | ||
| if ($uriinstanceof ControllerReference &&$this->containsNonScalars($uri->attributes)) { | ||
| @trigger_error('Passing objects as part of URI attributes to the ESI and SSI rendering strategies is deprecated since version 3.1, and will be removed in 4.0. Use a different rendering strategy or pass scalar values.',E_USER_DEPRECATED); | ||
| @trigger_error('Passing objectsor arraysas part of URI attributes to the ESI and SSI rendering strategies is deprecated since version 3.1, and will be removed in 4.0. Use a different rendering strategy or pass scalar values.',E_USER_DEPRECATED); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What about "Passing non scalar values [...]" instead?
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I hesitated because it is already written "pass scalar values" at the end, but if you think it is clearer, let's use it.
Member
xabbuh commentedJul 4, 2016
We should update the upgrade files too. |
729701b toe8ea461CompareMemberAuthor
chalasr commentedJul 4, 2016
I did the change. |
Member
fabpot commentedJul 4, 2016
👍 |
Member
xabbuh commentedJul 4, 2016
@chalasr The |
…ndererUpdate UPGRADE-3.1 tooUse non-scalar values as deperecated typeUpdate UPGRADE-4.0 too
e8ea461 tob088978CompareMemberAuthor
chalasr commentedJul 4, 2016
I missed it, it's ok now@xabbuh. |
Member
xabbuh commentedJul 4, 2016
👍 |
Member
fabpot commentedJul 4, 2016
Thank you@chalasr. |
fabpot added a commit that referenced this pull requestJul 4, 2016
… surrogate fragment renderer (chalasr)This PR was merged into the 3.1 branch.Discussion----------[HttpKernel] Clarify deprecation of non-scalar values in surrogate fragment renderer| Q | A| ------------- | ---| Branch? | 3.1| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19262| License | MIT| Doc PR | ~Commits-------b088978 [HttpKernel] Clarify deprecation of non-scalar values in surrogate renderer
fabpot added a commit that referenced this pull requestAug 27, 2016
…ragment renderer (chalasr)This PR was merged into the 3.1 branch.Discussion----------[HttpKernel] Fix assertion of deprecation in surrogate fragment renderer| Q | A| ------------- | ---| Branch? | 3.1| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aThe message has been changed in#19281 but not the corresponding assertionCommits-------4245bac [HttpKernel] Fix assertion of deprecation in fragment renderer
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.