Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed BC Layer in DoctrineChoiceLoader#19241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromRootie:patch-1
Jun 30, 2016
Merged

Fixed BC Layer in DoctrineChoiceLoader#19241

fabpot merged 1 commit intosymfony:masterfromRootie:patch-1
Jun 30, 2016

Conversation

@Rootie
Copy link
Contributor

QA
Branch?3.1
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

in the case when the BC Layer is used $idReader is not set to the right value.

in the case when the BC Layer is used $idReader is not set to the right value.
@fabpot
Copy link
Member

Thank you@Rootie.

@fabpotfabpot merged commitc44d71c intosymfony:masterJun 30, 2016
fabpot added a commit that referenced this pull requestJun 30, 2016
This PR was merged into the 3.2-dev branch.Discussion----------Fixed BC Layer in DoctrineChoiceLoader| Q             | A| ------------- | ---| Branch?       | 3.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |in the case when the BC Layer is used $idReader is not set to the right value.Commits-------c44d71c Fixed BC Layer in DoctrineChoiceLoader
@xabbuh
Copy link
Member

Where tests failing before? Otherwise we should add a test case to avoid future regressions.

@HeahDude
Copy link
Contributor

Thanks@Rootie for that PR!

@fabpotfabpot mentioned this pull requestOct 27, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Rootie@fabpot@xabbuh@HeahDude@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp