Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DoctrineBridge] fixed DoctrineChoiceLoaderTest by removing deprecated factory#19222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.1fromHeahDude:fix/doctrine_choice_loader-testsJun 29, 2016
Merged
[DoctrineBridge] fixed DoctrineChoiceLoaderTest by removing deprecated factory#19222
nicolas-grekas merged 1 commit intosymfony:3.1fromHeahDude:fix/doctrine_choice_loader-testsJun 29, 2016
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
HeahDude commentedJun 29, 2016
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
750640c to7d59499Compare| } | ||
| publicfunctiontestLegacyLoadChoiceList() | ||
| { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missing@group legacy annotation (can you please rebase while fixing?)
7d59499 to3f86eaeCompareMember
nicolas-grekas commentedJun 29, 2016
Thank you@HeahDude. |
nicolas-grekas added a commit that referenced this pull requestJun 29, 2016
…ing deprecated factory (HeahDude)This PR was merged into the 3.1 branch.Discussion----------[DoctrineBridge] fixed DoctrineChoiceLoaderTest by removing deprecated factory| Q | A| ------------- | ---| Branch? | 3.1| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | ~| License | MIT| Doc PR | ~Commits-------3f86eae [DoctrineBridge] fixed DoctrineChoiceLoaderTest by removing deprecated factory
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.