This makes the entity manager resettable by resetting its proxy, which should be more robust than resetting its service.
See first comments in#19192
Ping@stof

carsonbot added Status: Needs Review Feature Deprecation labels

Jun 28, 2016

nicolas-grekas force-pushed thelazy-reset branch frombcfdac7 tof5287aaCompare

June 28, 2016 14:07

nicolas-grekas mentioned this pull request

Jun 28, 2016

Deprecate Container::set() for non-synthetic services#19192

Closed

stof reviewed

Jun 28, 2016

View reviewed changes

src/Symfony/Bridge/Doctrine/ManagerRegistry.php Outdated

		}
		$manager->setProxyInitializer(
		function (&$wrappedInstance,LazyLoadingInterface$manager)use ($name) {
		$this->container->set($name,null);

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this does not solve the issue, as it is what will be deprecated

Copy link

Member

stof commentedJun 28, 2016

Status: needs work

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Jun 28, 2016

nicolas-grekas force-pushed thelazy-reset branch fromf5287aa to7444cccCompare

June 28, 2016 16:26

Copy link

MemberAuthor

nicolas-grekas commentedJun 28, 2016

Updated
Status: needs review

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Jun 28, 2016

nicolas-grekas force-pushed thelazy-reset branch 2 times, most recently from358a6bf to6bfdb82Compare

June 28, 2016 16:34

GuilhemN reviewed

Jun 28, 2016

View reviewed changes

src/Symfony/Bridge/Doctrine/ManagerRegistry.php Outdated

		if (isset($this->aliases[$name =strtolower($name)])) {
		$name =$this->aliases[$name];
		}
		$method ='get'.strtr($name,$this->underscoreMap).'Service';

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Isn't it possible instead to access the container methods map ?

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

BTW i guess we should somehow deprecate using another container than the one provided by symfony ?

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Method maps is now used also. We already are enforcing a symfony container, see type hint onContainerAwareTrait::setContainer

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Of course but the type hint istargeting the interface, and we can't know its internals.

nicolas-grekas force-pushed thelazy-reset branch 2 times, most recently from2efb9d2 to0315985Compare

June 29, 2016 07:43

Copy link

MemberAuthor

nicolas-grekas commentedJun 29, 2016•
edited
Loading

Implementation details & discussion following @Ener-Getickcomments:

the$container property is of typeContainerInterface but this interface doesn't provide any mean to get access to proxy initializers used for lazy services instanciation. My stand in this PR is that it is fine in this very case to get over the public interfaces and use the protected properties directly: the bridge is a Symfony managed package so that we have all the required tests & ci to ensure we won't break anything in the long run.
As far as custom container implementations are used into the wild, they should still be supported if they use the protected properties as expected. If this really exists (a custom incompatible container that generates LazyProxyInterfaces services), we can think later of new interfaces to allow what we're doing here but using public methods.

Yet, I think it's just fine to do direct access. Let's be pragmatic.

Copy link

Member

stof commentedJun 29, 2016

@nicolas-grekas would be great to debug CI failures

Copy link

MemberAuthor

nicolas-grekas commentedJun 29, 2016

@stof see#19217 (btw, votes welcomed on both this and that PRs ;) )

nicolas-grekas force-pushed thelazy-reset branch from0315985 toc112dc0Compare

June 29, 2016 20:17

[Bridge/Doctrine] Reset the EM lazy-proxy instead of the EM service

c581cd4

nicolas-grekas force-pushed thelazy-reset branch fromc112dc0 toc581cd4Compare

July 1, 2016 06:19

Copy link

Member

fabpot commentedJul 1, 2016

Thank you@nicolas-grekas.

fabpot merged commitc581cd4 intosymfony:master

Jul 1, 2016

fabpot added a commit that referenced this pull request

Jul 1, 2016

feature#19203[Bridge/Doctrine] Reset the EM lazy-proxy instead of t…

62f0dbf

…he EM service (nicolas-grekas)This PR was merged into the 3.2-dev branch.Discussion----------[Bridge/Doctrine] Reset the EM lazy-proxy instead of the EM service| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | no| Fixed tickets | -| License       | MIT| Doc PR        | -This makes the entity manager resettable by resetting its proxy, which should be more robust than resetting its service.See first comments in#19192Ping@stofCommits-------c581cd4 [Bridge/Doctrine] Reset the EM lazy-proxy instead of the EM service

Copy link

Member

stof commentedJul 13, 2016

@nicolas-grekas you forgot the second half of this task: opening a PR on DoctrineBundle to mark the EM services as lazy so that a proxy is generated for them.

stof mentioned this pull request

Jul 13, 2016

Make the EntityManager resettabledoctrine/orm#5933

Open

fprochazka mentioned this pull request

Jul 15, 2016

Use ocramius/proxy-manager to make EM resetableKdyby/Doctrine#280

Open

nicolas-grekas deleted the lazy-reset branch

July 18, 2016 05:35

nicolas-grekas mentioned this pull request

Jul 24, 2016

Set doctrine.orm.entity_manager.abstract as lazydoctrine/DoctrineBundle#559

Merged

ro0NL mentioned this pull request

Aug 19, 2016

[DI] Deprecate Container::set for nulls, initialized and alias services#19668

Closed

fabpot mentioned this pull request

Oct 27, 2016

Release v3.2.0-BETA1#20317

Merged

Copy link

gregoirepaqueron commentedApr 13, 2017

How to set entity managers lazy by default doctrine configuration ?

My conf :

doctrine:orm:auto_generate_proxy_classes:"%kernel.debug%"default_entity_manager:defaultentity_managers:sso:connection:ssomappings:GsoiJNumAdminMainBundle:type:"annotation"dir:"Entity/SSO"prefix:"MyPrefix\\Entity\\SSO"

When i want to reset the manager, i got the deprecation message :
User Deprecated: Resetting a non-lazy manager service is deprecated since Symfony 3.2 and will throw an exception in version 4.0. Set the "doctrine.orm.sso_entity_manager" service as lazy and require "symfony/proxy-manager-bridge" in your composer.json file instead.

with this code :

$this->container->get('doctrine')->resetManager('sso');

Copy link

Member

stof commentedApr 13, 2017

installocramius/proxy_manager so that a proxy can be generated to actually make the service lazy (requiring the bridge itself won't do the trick when using the fullstack repo as it replaces the bridge but does not enforce installing the library).
DoctrineBundle already marks the service as lazy (if you use the latest version of the bundleà