Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] removed unneeded private methods#19163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromfabpot:lock-simplification
Jun 24, 2016

Conversation

@fabpot
Copy link
Member

QA
Branch?2.7
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketshttps://github.com/symfony/symfony/pull/19134/files/3871e1a95056ce8278e6b86d3e8005836ecab954#r68286709
LicenseMIT
Doc PRn/a

@fabpotfabpot merged commit35f32eb intosymfony:2.7Jun 24, 2016
fabpot added a commit that referenced this pull requestJun 24, 2016
This PR was merged into the 2.7 branch.Discussion----------[Console] removed unneeded private methods| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |https://github.com/symfony/symfony/pull/19134/files/3871e1a95056ce8278e6b86d3e8005836ecab954#r68286709| License       | MIT| Doc PR        | n/aCommits-------35f32eb [Console] removed unneeded private methods
@rquadling
Copy link
Contributor

rquadling commentedJun 24, 2016•
edited
Loading

OOI, why not have this as a local static? It really is only of use in this 1 method (and was were I placed it originally) :-D

@jvasseur
Copy link
Contributor

Method static vars are shared by all instances of a class so it wouldn't work here.

rquadling reacted with thumbs up emoji

@rquadling
Copy link
Contributor

Of course they are! (Hangs head in shame!)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabpot@rquadling@jvasseur@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp