Was part of#17706.
Change the remainingisset($config['foo']) to$this->isConfigEnabled($config['foo']) to allow to use parameters to enable a feature.

carsonbot added Status: Needs Review FrameworkBundle labels

Jun 23, 2016

Copy link

Member

stof commentedJun 23, 2016

The fact that it does not change the Configuration class looks weird to me

Copy link

ContributorAuthor

GuilhemN commentedJun 23, 2016

@stofcanBeEnabled is used in theConfiguration so it's ok. In fact it's possible that this was broken, i'll run some checks.

Copy link

ContributorAuthor

GuilhemN commentedJun 23, 2016

@stof ok in fact the$this->isConfigEnabled() is inside theregister* functions.
Anyway this still looks inconsistent to me, imo we should move this checks to the main function, wdyt?

Copy link

Member

xabbuh commentedJun 23, 2016

At least, I would now remove the second call to theisConfigEnabled() method insideregisterSerializerConfiguration() andregisterPropertyInfoConfiguration().

GuilhemN force-pushed theFRAMEWORKEXTENSION branch froma02ee60 toc30f0b0Compare

June 23, 2016 20:21

GuilhemN changed the title~~[FrameworkBundle] Fix small inconsistensies~~[FrameworkBundle] Fix redundant code

Jun 23, 2016

[FrameworkBundle] Remove redundant code

a21af88

GuilhemN changed the title~~[FrameworkBundle] Fix redundant code~~[FrameworkBundle] Remove redundant code

Jun 23, 2016

GuilhemN force-pushed theFRAMEWORKEXTENSION branch fromc30f0b0 toa21af88Compare

June 23, 2016 20:21

Copy link

ContributorAuthor

GuilhemN commentedJun 23, 2016

done@xabbuh

Copy link

Member

xabbuh commentedJun 23, 2016

👍 LGTM

Copy link

Member

fabpot commentedJun 24, 2016

Thank you @Ener-Getick.

fabpot merged commita21af88 intosymfony:master

Jun 24, 2016

fabpot added a commit that referenced this pull request

Jun 24, 2016

minor#19155[FrameworkBundle] Remove redundant code (Ener-Getick)

358a4cc

This PR was merged into the 3.2-dev branch.Discussion----------[FrameworkBundle] Remove redundant code| Q             | A| ------------- | ---| Branch?       | "master"| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Was part of#17706.Change the remaining ``isset($config['foo'])`` to ``$this->isConfigEnabled($config['foo'])`` to allow to use parameters to enable a feature.Commits-------a21af88 [FrameworkBundle] Remove redundant code

GuilhemN deleted the FRAMEWORKEXTENSION branch

June 24, 2016 06:23