Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Response headers fix#19143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Response headers fix#19143
Uh oh!
There was an error while loading.Please reload this page.
Conversation
8e775f3 to429034fCompare| { | ||
| if (!$this->cacheControl && !$this->has('ETag') && !$this->has('Last-Modified') && !$this->has('Expires')) { | ||
| return'no-cache'; | ||
| return'no-cache, private'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Addingprivate is what we are doing by default line 299 in the same situation.
| $bag1 =newResponseHeaderBag($headers); | ||
| $bag2 =newResponseHeaderBag($bag1->allPreserveCase()); | ||
| //print_r($bag1->allPreserveCase()); | ||
| //print_r($bag2->allPreserveCase()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Theseprint_r() weren't removed.
nicolas-grekas commentedJun 22, 2016
👍 (on 3.2 or as bug fix either) |
romainneutron commentedJun 23, 2016
👍 |
This PR was merged into the 3.2-dev branch.Discussion----------Response headers fix| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | yes/no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#16171,#16307| License | MIT| Doc PR | n/aTo fix the inconsistency mentioned in#16171, I think the "best" solution would be to add `private` when cache-control is not set, which was the intention but was forgotten.I propose to make the fix in 3.2 only as it might be a BC break.Commits-------66afa01 [HttpFoundation] added private by default when setting Cache-Control to no-cache
To fix the inconsistency mentioned in#16171, I think the "best" solution would be to add
privatewhen cache-control is not set, which was the intention but was forgotten.I propose to make the fix in 3.2 only as it might be a BC break.