Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Avoid phpunit 5.4 warnings on getMock (2.7+)#19128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJun 21, 2016
Is this the only class that would need an update? |
xabbuh commentedJun 21, 2016
By the way, according to our newmaintenance document we must do this change in the
|
linaori commentedJun 21, 2016
@xabbuh I've made a new PR (master) for the other changes as they are only in the master. This is not a major version though, this is a minor (5.1 vs 5.4), thus I think it should be merged upwards as it's a minor change anyway. |
Tobion commentedJun 21, 2016
👍 |
1 similar comment
stof commentedJun 21, 2016
👍 |
nicolas-grekas commentedJun 21, 2016
Thank you@iltar. |
This PR was merged into the 2.7 branch.Discussion----------Avoid phpunit 5.4 warnings on getMock (2.7+)| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19125| License | MIT| Doc PR | ~Avoids calling `getMock()` in phpunit 5.4 which will trigger a warning (and thus failing test suite) when used by developers as this TestCase is an extension point.Commits-------b05014c Avoid phpunit 5.4 warnings on getMock
This PR was merged into the 3.2-dev branch.Discussion----------Avoid phpunit 5.4 warnings on getMock (master)| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19125| License | MIT| Doc PR | ~Avoids calling `getMock()` in phpunit 5.4 which will trigger a warning (and thus failing test suite) when used by developers as this TestCase is an extension point._in the other branches (opposed to#19128), this was not in the `Test` namespace yet but in `Tests`. Therefore I've only added this in the master as changed by@wouterj ine938361._Commits-------eb8c27e Avoid phpunit 5.4 warnings on getMock
Avoids calling
getMock()in phpunit 5.4 which will trigger a warning (and thus failing test suite) when used by developers as this TestCase is an extension point.