Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] use call_user_func() for PHP 5.3 compatibility#19126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Not all callables can be called directly on PHP 5.3 (for example,`array('className', 'methodName')` does not work).fabpot commentedJun 21, 2016
But Symfony 3.x does not support PHP 5.3 anymore. |
xabbuh commentedJun 21, 2016
No, but we explicitly support PHP 5.3 for the PHPUnit bridge to use the latest version in tests for older Symfony versions for example (seehttps://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/PhpUnit/composer.json#L19-L21). |
fabpot commentedJun 21, 2016
Thank you@xabbuh. |
…lity (xabbuh)This PR was merged into the 3.2-dev branch.Discussion----------[PhpUnitBridge] use call_user_func() for PHP 5.3 compatibility| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Not all callables can be called directly on PHP 5.3 (for example, `array('className', 'methodName')` does not work).Commits-------8549e05 use call_user_func() for PHP 5.3 compatibilitynicolas-grekas commentedJun 21, 2016 via email
À priori 👎Because no code has yet been written with the 5.3 unsupported style, thusthere is nothing to fix. |
xabbuh commentedJun 21, 2016
@nicolas-grekas Yeah, but that doesn't mean that someone wants to use this in their own project outside Symfony. Why should we not make their lives easier? |
Not all callables can be called directly on PHP 5.3 (for example,
array('className', 'methodName')does not work).