Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] remove BC breaking argument#19072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJun 16, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18999 (comment) |
| License | MIT |
| Doc PR |
chalasr commentedJun 16, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
👍 Good catch, thank you@xabbuh. It's even better to don't have it as a real argument. |
| $triggerDeprecationError =func_get_arg(0); | ||
| } | ||
| if ($triggerDeprecationError) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what about:if (0 < func_num_args() && func_get_arg(0)) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess you mean0 === func_num_args() || func_get_arg(0)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fine for me :)
nicolas-grekas commentedJun 16, 2016
👍 |
| { | ||
| if ($triggerDeprecationError) { | ||
| if (0 ===func_num_args() ||func_get_arg(0)) { | ||
| @trigger_error(sprintf('The %s() method is deprecated since version 3.2 and will be removed in 4.0. Use %s:getStream() instead.',__METHOD__, StreamableInputInterface::class),E_USER_DEPRECATED); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should be%s::getStream(), isn't it? (double colon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry...@xabbuh Can you please BTW fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same typo on the setter... I will open a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
See#19073
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@chalasr Sorry, I missed that comment. Thank you for creating the PR.
nicolas-grekas commentedJun 16, 2016
Thank you@xabbuh. |
This PR was merged into the 3.2-dev branch.Discussion----------[Console] remove BC breaking argument| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#18999 (comment)| License | MIT| Doc PR |Commits-------f574330 remove BC breaking argument
…warning (chalasr)This PR was merged into the 3.2-dev branch.Discussion----------Fix the missing colon in get/setInputStream deprecation warning| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19072 (comment)| License | MIT| Doc PR | ~Commits-------0d6dc8e Fix the missing colon in get/setInputStream deprecation warning