Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Use UPSERT for sessions stored in PgSql >= 9.5#19048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJun 14, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| switch ($platform) { | ||
| case'mysql': | ||
| switch (true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
bonus fix:https://github.com/symfony/symfony/pull/19048/files#diff-e6a5cc5d66fa241233b3314fcd49f228R236 is dead code today
fabpot commentedJun 14, 2016
👍 |
Tobion commentedJun 14, 2016
Please updatehttps://github.com/nicolas-grekas/symfony/blob/0b5b693f19915a263630ea85bc3cce208f9bad9d/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/PdoSessionHandler.php#L350 to say "like in Postgres < 9.5" to avoid confusion. Apart from that 👍 |
nicolas-grekas commentedJun 14, 2016
updated |
fabpot commentedJun 14, 2016
Thank you@nicolas-grekas. |
…= 9.5 (nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[HttpFoundation] Use UPSERT for sessions stored in PgSql >= 9.5| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Commits-------9569c74 [HttpFoundation] Use UPSERT for sessions stored in PgSql >= 9.5
…(stof)This PR was merged into the 2.7 branch.Discussion----------Fix the DBAL session handler version check for Postgresql| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | no| Fixed tickets | n/a| License | MIT| Doc PR | n/a#19048 broken the DBAL session handler when using Postgresql by using method which does not exist on the main DBAL Connection class.Commits-------e98c584 Fix the DBAL session handler version check for Postgresql