Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
add docblock type elements to support newly added IteratorAggregate::getIterator PhpStorm support#19036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| *{@inheritdoc} | ||
| *@return ChoiceGroupView[]|ChoiceView[] | ||
| */ | ||
| publicfunctiongetIterator() |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Perhaps the inheritdoc can stay. If I understand correctly how it is supposed to work,{@inheritdoc} only imports the (long) description.
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
indeed 👍
Member
fabpot commentedJun 16, 2016
@Haehnchen Can you finish this PR? |
bcf33f1 to21e584fCompare…getIterator PhpStorm support
21e584f toede3556CompareContributorAuthor
Haehnchen commentedJun 17, 2016
@fabpot done |
Member
nicolas-grekas commentedJun 17, 2016
Thank you@Haehnchen. |
nicolas-grekas added a commit that referenced this pull requestJun 17, 2016
…orAggregate::getIterator PhpStorm support (Haehnchen)This PR was merged into the 2.7 branch.Discussion----------add docblock type elements to support newly added IteratorAggregate::getIterator PhpStorm support| Q | A| ------------- | ---| Branch | 2.7| Bug fix | no| New feature | no| BC breaks | no| Deprecations | no| Tests pass | yes| License | MITIn additional to#16965 PhpStorm supports `IteratorAggregate::getIterator` now. seehttps://blog.jetbrains.com/phpstorm/2016/06/phpstorm-2016-2-eap-162-844/example```$collection = new \Symfony\Component\Routing\RouteCollection();foreach ($collection as $route) { $route->getHost();}```Commits-------ede3556 add docblock type elements to support newly added IteratorAggregate::getIterator PhpStorm support
Haehnchen added a commit to Haehnchen/shopware-platform that referenced this pull requestFeb 22, 2019
I was just "playing" with the cart. stacking class together as i noticed collections do not provide ide support. This is just a example for one collection to support autocompletion.So also how this was implemented in Symfony:symfony/symfony#19036``` $cart = new \Shopware\Core\Checkout\Cart\Cart(); $cart->getLineItems()[0]->getDescription(); foreach ($cart->getLineItems() as $item) { $item->getDescription(); }```
shopwareBot pushed a commit to shopware/shopware that referenced this pull requestFeb 25, 2019
I was just "playing" with the cart. stacking class together as i noticed collections do not provide ide support. This is just a example for one collection to support autocompletion.So also how this was implemented in Symfony:symfony/symfony#19036``` $cart = new \Shopware\Core\Checkout\Cart\Cart(); $cart->getLineItems()[0]->getDescription(); foreach ($cart->getLineItems() as $item) { $item->getDescription(); }```fixes#18
shopwareBot pushed a commit to shopware/core that referenced this pull requestFeb 25, 2019
I was just "playing" with the cart. stacking class together as i noticed collections do not provide ide support. This is just a example for one collection to support autocompletion.So also how this was implemented in Symfony:symfony/symfony#19036``` $cart = new \Shopware\Core\Checkout\Cart\Cart(); $cart->getLineItems()[0]->getDescription(); foreach ($cart->getLineItems() as $item) { $item->getDescription(); }```fixes#18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In additional to#16965 PhpStorm supports
IteratorAggregate::getIteratornow. seehttps://blog.jetbrains.com/phpstorm/2016/06/phpstorm-2016-2-eap-162-844/example