Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Add path argument to dump a specific option in debug:config#18940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
d7db137 to8115a4bCompareHandle failure on undefined path, Add testsPHPDoc fixRemove useless assertion
| */ | ||
| privatefunctiongetConfigForPath(array$config =array(),$path,$alias) | ||
| { | ||
| $steps =explode('.',$path); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What about using aPropertyAccessor instead?
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It would be nice but dot notation seems to be supported for objects only.
$array = array('foo' => array('bar' => 'value'));$value = PropertyAccessor::getValue($arr, 'foo.bar');GIves
Cannot read property "foo" from an array. Maybe you intended to write the property path as "[foo]" instead.
It needs to bePropertyAccessor::getValue($array, '[foo][bar]').
Is there a real gain to parse the propertyPath then wrap each level in[level] for finally use the property accessor?
Member
fabpot commentedJun 13, 2016
Thank you@chalasr. |
fabpot added a commit that referenced this pull requestJun 13, 2016
…in debug:config (chalasr)This PR was merged into the 3.2-dev branch.Discussion----------[Console] Add path argument to dump a specific option in debug:config| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aThis adds the ability to dump a specific bundle config option from the `debug:config` command.For instance `debug:config StofDoctrineExtensionsBundle uploadable` gives:I hesitated to just look for a `.` in the `name` argument rather than adding a `path` argument that doesn't include the bundle alias (that is took from the first argument of the command), let me know what you think about that.Commits-------05ae01b [Console] Add path argument to dump a specific option in debug:config
Merged
nicolas-grekas added a commit that referenced this pull requestNov 25, 2016
…t in debug:config (chalasr)This PR was merged into the 3.2 branch.Discussion----------[FrameworkBundle] Add missing example for 'path' argument in debug:config| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aThe argument has been introduced in#18940 .Commits-------c6b7aeb Add missing example for 'path' argument in debug:config
fabpot added a commit that referenced this pull requestJan 10, 2017
…ig reference sub-path (ogizanagi)This PR was merged into the 3.3-dev branch.Discussion----------[Config][FrameworkBundle] Allow to dump extension config reference sub-path| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/ASame as#18940 but for the `config:dump-reference` command:<img width="975" alt="screenshot 2016-11-29 a 19 09 04" src="https://cloud.githubusercontent.com/assets/2211145/20722577/6c9f9b98-b667-11e6-9683-9a304ff80895.PNG">Only available for yaml, because it's the most common format when developing an end-application, and dumping a sub xml document causes some issues and raises more questions with the current `XmlReferenceDumper` implementation (namespaces, root name, ...).Commits-------869bb15 [Config][FrameworkBundle] Allow to dump extension config reference sub path
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestJan 10, 2017
…ig reference sub-path (ogizanagi)This PR was merged into the 3.3-dev branch.Discussion----------[Config][FrameworkBundle] Allow to dump extension config reference sub-path| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/ASame assymfony/symfony#18940 but for the `config:dump-reference` command:<img width="975" alt="screenshot 2016-11-29 a 19 09 04" src="https://cloud.githubusercontent.com/assets/2211145/20722577/6c9f9b98-b667-11e6-9683-9a304ff80895.PNG">Only available for yaml, because it's the most common format when developing an end-application, and dumping a sub xml document causes some issues and raises more questions with the current `XmlReferenceDumper` implementation (namespaces, root name, ...).Commits-------869bb1530b [Config][FrameworkBundle] Allow to dump extension config reference sub path
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This adds the ability to dump a specific bundle config option from the
debug:configcommand.For instance
debug:config StofDoctrineExtensionsBundle uploadablegives:I hesitated to just look for a
.in thenameargument rather than adding apathargument that doesn't include the bundle alias (that is took from the first argument of the command), let me know what you think about that.