Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fixed singular of committee#18911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| } | ||
| $irregularNouns =array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
would be better as a private static var
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I had it like that prior to the PR but since those are irregular nouns in that context I have moved that into the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Inline arrays are can't benefit from some opcache optims until php7. A private static would fix that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shall I update it accordingly? I prefered the logic reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@nicolas-grekas Shall I refactor it? I would like to get this merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yep please
peterrehm commentedMay 30, 2016
@nicolas-grekas Updated |
peterrehm commentedJun 5, 2016
@nicolas-grekas Both PR's are updated |
peterrehm commentedJun 5, 2016
Just added support for |
fabpot commentedJun 8, 2016
Thank you@peterrehm. |
This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes#18911).Discussion----------Fixed singular of committee| Q | A| ------------- | ---| Branch? | 2.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#18872,#18748| License | MIT| Doc PR | -In addition to PR#18909.Commits-------5661d52 Fixed singular of committee
Uh oh!
There was an error while loading.Please reload this page.
In addition to PR#18909.