Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] force enabling the external XML entity loaders#18908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedMay 29, 2016
| Q | A |
|---|---|
| Branch? | 2.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18876 |
| License | MIT |
| Doc PR |
Member
nicolas-grekas commentedMay 30, 2016
Do we have the same issue in XliffFileLoader.php and XmlUtils.php? |
Member
nicolas-grekas commentedMay 30, 2016
Thank you@xabbuh. |
nicolas-grekas added a commit that referenced this pull requestMay 30, 2016
…ty loaders (xabbuh)This PR was merged into the 2.3 branch.Discussion----------[DependencyInjection] force enabling the external XML entity loaders| Q | A| ------------- | ---| Branch? | 2.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#18876| License | MIT| Doc PR |Commits-------142b1a4 force enabling the external XML entity loaders
Contributor
sstok commentedMay 30, 2016
@nicolas-grekas It seems so,https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Translation/Loader/schema/dic/xliff-core/xliff-core-1.2-strict.xsd#L33 I wonder if this will not load the external resources of the to be validated XML document, which would break the security system that was introduced 😨 can this be checked somehow? |
Member
nicolas-grekas commentedMay 30, 2016
Reverted because this look suspicious and need more thought. |
MemberAuthor
xabbuh commentedMay 30, 2016
Merged
fabpot added a commit that referenced this pull requestJun 6, 2016
* 2.3: updated VERSION for 2.3.42 update CONTRIBUTORS for 2.3.42 updated CHANGELOG for 2.3.42 Revert "bug#18908 [DependencyInjection] force enabling the external XML entity loaders (xabbuh)" Partial revert of previous PR [DependencyInjection] Skip deep reference check for 'service_container' Catch \Throwable [Serializer] Add missing@throws annotations Fix for#18843 force enabling the external XML entity loaders Removed UTC specification with timestamp
nicolas-grekas added a commit that referenced this pull requestJun 6, 2016
* 2.7: `@throws` annotations should go after `@return` Fix merge updated VERSION for 2.3.42 update CONTRIBUTORS for 2.3.42 updated CHANGELOG for 2.3.42 Revert "bug#18908 [DependencyInjection] force enabling the external XML entity loaders (xabbuh)" Partial revert of previous PR [DependencyInjection] Skip deep reference check for 'service_container' Catch \Throwable [Serializer] Add missing@throws annotations Fix for#18843 force enabling the external XML entity loaders Removed UTC specification with timestampConflicts:src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.phpsrc/Symfony/Component/Finder/Finder.phpsrc/Symfony/Component/Security/Acl/Dbal/MutableAclProvider.phpsrc/Symfony/Component/Security/Acl/Domain/ObjectIdentity.phpsrc/Symfony/Component/Security/Acl/Model/AclInterface.phpsrc/Symfony/Component/Security/Acl/Model/MutableAclProviderInterface.phpsrc/Symfony/Component/Security/Acl/Permission/MaskBuilder.phpsrc/Symfony/Component/Translation/Loader/XliffFileLoader.phpsrc/Symfony/Component/Yaml/Tests/InlineTest.php
nicolas-grekas added a commit that referenced this pull requestJun 6, 2016
* 2.8: `@throws` annotations should go after `@return` Fix merge updated VERSION for 2.3.42 update CONTRIBUTORS for 2.3.42 updated CHANGELOG for 2.3.42 Revert "bug#18908 [DependencyInjection] force enabling the external XML entity loaders (xabbuh)" Partial revert of previous PR [DependencyInjection] Skip deep reference check for 'service_container' Catch \Throwable [Serializer] Add missing@throws annotations Fix for#18843 force enabling the external XML entity loaders Removed UTC specification with timestampConflicts:CHANGELOG-2.3.mdsrc/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.phpsrc/Symfony/Bundle/TwigBundle/Extension/AssetsExtension.phpsrc/Symfony/Component/Config/Loader/FileLoader.phpsrc/Symfony/Component/DependencyInjection/Container.phpsrc/Symfony/Component/DependencyInjection/ContainerBuilder.phpsrc/Symfony/Component/Finder/Expression/Expression.phpsrc/Symfony/Component/Finder/Finder.phpsrc/Symfony/Component/HttpKernel/DependencyInjection/ContainerAwareHttpKernel.phpsrc/Symfony/Component/HttpKernel/HttpCache/HttpCache.php
nicolas-grekas added a commit that referenced this pull requestJun 6, 2016
* 3.0: `@throws` annotations should go after `@return` Fix merge updated VERSION for 2.3.42 update CONTRIBUTORS for 2.3.42 updated CHANGELOG for 2.3.42 Revert "bug#18908 [DependencyInjection] force enabling the external XML entity loaders (xabbuh)" Partial revert of previous PR [DependencyInjection] Skip deep reference check for 'service_container' Catch \Throwable [Serializer] Add missing@throws annotations Fix for#18843 force enabling the external XML entity loaders Removed UTC specification with timestampConflicts:src/Symfony/Component/Yaml/Tests/InlineTest.php
nicolas-grekas added a commit that referenced this pull requestJun 6, 2016
* 3.1: `@throws` annotations should go after `@return` Fix merge updated VERSION for 2.3.42 update CONTRIBUTORS for 2.3.42 updated CHANGELOG for 2.3.42 Revert "bug#18908 [DependencyInjection] force enabling the external XML entity loaders (xabbuh)" Partial revert of previous PR [DependencyInjection] Skip deep reference check for 'service_container' Catch \Throwable [Serializer] Add missing@throws annotations Fix for#18843 force enabling the external XML entity loaders Removed UTC specification with timestamp
This was referencedJun 6, 2016
Merged
Merged
Merged
fabpot added a commit that referenced this pull requestJun 13, 2016
…ty loaders (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[DependencyInjection] force enabling the external XML entity loaders| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#18876,#18908| License | MIT| Doc PR |Commits-------12b5509 force enabling the external XML entity loaders
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.