NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Fix js comment in profiler#18883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:2.7fromlinnaea:patch-1

May 26, 2016

Merged

Fix js comment in profiler#18883

fabpot merged 1 commit intosymfony:2.7fromlinnaea:patch-1

May 26, 2016

Conversation

Copy link

Contributor

linnaea commentedMay 26, 2016

Q	A
Branch?	2.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

Single line comment introduced in#18413 causes the toolbar to fail to load with a syntax error.

Fix js comment in profiler

91a2f5d

carsonbot added Status: Needs Review Bug labels

May 26, 2016

Copy link

Member

javiereguiluz commentedMay 26, 2016

👍

Status: Reviewed

carsonbot added Status: Reviewed and removed Status: Needs Review labels

May 26, 2016

javiereguiluz added the WebProfilerBundle label

May 26, 2016

Copy link

Member

xabbuh commentedMay 26, 2016

👍

Copy link

Member

fabpot commentedMay 26, 2016

Thank you@linnaea.

fabpot merged commit91a2f5d intosymfony:2.7

May 26, 2016

fabpot added a commit that referenced this pull request

May 26, 2016

bug#18883Fix js comment in profiler (linnaea)

5dcbbd0

This PR was merged into the 2.7 branch.Discussion----------Fix js comment in profiler| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Single line comment introduced in#18413 causes the toolbar to fail to load with a syntax error.Commits-------91a2f5d Fix js comment in profiler