Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Create NullAdapter to disable cache if needed#18825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedMay 20, 2016
085ca60 toa3e8e4dCompare| */ | ||
| class NullAdapter implements AdapterInterface | ||
| { | ||
| private $createCacheItem; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
phpdoc missing
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We don't add phpdoc on private properties when IDEs are able to infer the type from the constructor (which is the case here)
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks for your feedback 👍
Member
nicolas-grekas commentedMay 25, 2016
👍 |
ContributorAuthor
tgalopin commentedMay 25, 2016
I added the LF. |
Member
nicolas-grekas commentedMay 26, 2016
Thank you@tgalopin. |
nicolas-grekas added a commit that referenced this pull requestMay 26, 2016
…(tgalopin)This PR was merged into the 3.2-dev branch.Discussion----------[Cache] Create NullAdapter to disable cache if needed| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | WIP| Fixed tickets | -| License | MIT| Doc PR | -Tthis PR aims to implement a Symfony Cache Null adapter able to disable cache if needed (very useful in tests or in the case of the fallback of the OpCacheAdapter for instance).This PR is required by#18823 and#18533Commits-------0519d22 [Cache] Create NullAdapter to disable cache if needed
fabpot added a commit that referenced this pull requestJun 28, 2016
…P 7.0 (tgalopin)This PR was merged into the 3.2-dev branch.Discussion----------[Cache] Add PhpArrayAdapter to use shared memory on PHP 7.0| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | WIP| Fixed tickets | -| License | MIT| Doc PR | -Depends on#18825This PR aims to implement a Symfony Cache adapter able to build files optimized for OPCache memory storage. Any kind of static data that can be warmed up is a candidate for OPcache storage.This PR is limited to the implementation of the Adapter. It's usage in the annotations caching system is implemented in the PR#18533. The aim is also to use this adapter in other contexts (validator, serializer, ...).Commits-------28a40d2 [Cache] Add PhpArrayAdapter to use shared memory on PHP 7.0+
fabpot added a commit that referenced this pull requestJul 30, 2016
…e warmer for annotations (tgalopin)This PR was squashed before being merged into the 3.2-dev branch (closes#18533).Discussion----------[FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | WIP| Fixed tickets | -| License | MIT| Doc PR | -Depends on#18825 and#18823This PR implements the usage of the new OpCacheAdapter in the annotations caching system. The idea to use this adapter as much as possible in Symfony (validator, serializer, ...). These other implementations will be the object of different PRs.Commits-------f950a2b [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations
symfony-splitter pushed a commit to symfony/cache that referenced this pull requestJul 30, 2016
…e warmer for annotations (tgalopin)This PR was squashed before being merged into the 3.2-dev branch (closes #18533).Discussion----------[FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | WIP| Fixed tickets | -| License | MIT| Doc PR | -Depends onsymfony/symfony#18825 andsymfony/symfony#18823This PR implements the usage of the new OpCacheAdapter in the annotations caching system. The idea to use this adapter as much as possible in Symfony (validator, serializer, ...). These other implementations will be the object of different PRs.Commits-------f950a2b [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations
symfony-splitter pushed a commit to symfony/http-kernel that referenced this pull requestJul 30, 2016
…e warmer for annotations (tgalopin)This PR was squashed before being merged into the 3.2-dev branch (closes #18533).Discussion----------[FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | WIP| Fixed tickets | -| License | MIT| Doc PR | -Depends onsymfony/symfony#18825 andsymfony/symfony#18823This PR implements the usage of the new OpCacheAdapter in the annotations caching system. The idea to use this adapter as much as possible in Symfony (validator, serializer, ...). These other implementations will be the object of different PRs.Commits-------f950a2b [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestJul 30, 2016
…e warmer for annotations (tgalopin)This PR was squashed before being merged into the 3.2-dev branch (closes #18533).Discussion----------[FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | WIP| Fixed tickets | -| License | MIT| Doc PR | -Depends onsymfony/symfony#18825 andsymfony/symfony#18823This PR implements the usage of the new OpCacheAdapter in the annotations caching system. The idea to use this adapter as much as possible in Symfony (validator, serializer, ...). These other implementations will be the object of different PRs.Commits-------f950a2b [FrameworkBundle] Wire PhpArrayAdapter with a new cache warmer for annotations
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tthis PR aims to implement a Symfony Cache Null adapter able to disable cache if needed (very useful in tests or in the case of the fallback of the OpCacheAdapter for instance).
This PR is required by#18823 and#18533