Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Show aliases in command description instead of in different lines in application description#18790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| { | ||
| $text =''; | ||
| $aliases =$command->getAliases(); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if ($aliases) {
nicolas-grekas commentedMay 19, 2016
👍 as new feature on master, after comments are fixed |
juanmirod commentedMay 19, 2016
Hi@nicolas-grekas thanks for the review, I think I amended all your comments. |
GuilhemN commentedJun 8, 2016
Looks great 👍 ! |
fabpot commentedJun 8, 2016
Thank you@juanmirod. |
juanmirod commentedJun 18, 2016
Thanks to you, I am glad to have contributed to the project. |
Uh oh!
There was an error while loading.Please reload this page.
This PR is a suggestion about the bug referenced in ticket 18351. The problem is that aliases create new lines with identical descriptions in the application description, it is suggested to show the aliases in the command description.
I had to modify one application fixture to meet this new behaviour and make the tests pass, but I don't think that a new application fixture is needed to test this having the application fixture 2.
Comments are welcome, this is my first PR in Symfony so if I need to meet any more requirements to make it correct to merge just tell me please.