Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Test & tweak CacheItem::validateKey()#18604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| class CacheItemTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| public function testValideKey() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ValidKey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
1333d30 to1fccfb8Compare1fccfb8 to4256addComparejaviereguiluz commentedApr 20, 2016
👍 It looks very nice to me. @nicolas-grekas thanks for this PR ... and thanks for your patience 🙏 |
nicolas-grekas commentedApr 20, 2016
Thanks to you@javiereguiluz , you had a good point, sorry for merging too fast today :) |
…rekas)This PR was merged into the 3.1-dev branch.Discussion----------[Cache] Test & tweak CacheItem::validateKey()| Q | A| ------------- | ---| Branch? | 3.1| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Ping@javiereguiluz@stofCommits-------4256add [Cache] Test & tweak CacheItem::validateKey()
Ping@javiereguiluz@stof