Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Fix internal caching in AutowirePass#18596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * @param Definition $definition | ||
| * | ||
| * @return \ReflectionClass|null | ||
| * @return \ReflectionClass|false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why false ? null is a better return value for the absence of value than using a boolean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because isset checks are in use
dunglas commentedApr 20, 2016
👍 |
This PR was merged into the 2.8 branch.Discussion----------[DI] Fix internal caching in AutowirePass| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -ping@dunglasCommits-------ed2e236 [DI] Fix internal caching in AutowirePass
ping@dunglas