NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Console] [TableHelper] make it work with SymfonyStyle.#18581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:2.7fromaitboudad:issue_18573

Apr 20, 2016

Merged

[Console] [TableHelper] make it work with SymfonyStyle.#18581

fabpot merged 1 commit intosymfony:2.7fromaitboudad:issue_18573

Apr 20, 2016

Conversation

Copy link

Contributor

aitboudad commentedApr 18, 2016

Q	A
Branch?	2.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	no
Fixed tickets	#18573
License	MIT
Doc PR	~

aitboudad added the Console label

Apr 18, 2016

carsonbot added the Status: Needs Review label

Apr 18, 2016

aitboudad force-pushed theissue_18573 branch fromfba795d to8802547Compare

April 18, 2016 15:42

javiereguiluz added the Bug label

Apr 19, 2016

javiereguiluz reviewed

Apr 19, 2016

View reviewed changes

src/Symfony/Component/Console/Tests/Fixtures/Style/SymfonyStyle/command/command_8.php Outdated

		use Symfony\Component\Console\Tests\Style\SymfonyStyleWithForcedLineLength;
		use Symfony\Component\Console\Helper\TableCell;

		//Ensure questions do not output anything when input is non-interactive

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This comment needs to be updated.

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

done

Copy link

Member

javiereguiluz commentedApr 19, 2016

👍

javiereguiluz added Status: Reviewed and removed Status: Needs Review labels

Apr 19, 2016

[Console] [TableHelper] make it work with SymfonyStyle.

43cc93c

aitboudad force-pushed theissue_18573 branch from8802547 to43cc93cCompare

April 19, 2016 11:28

nicolas-grekas reviewed

Apr 19, 2016

View reviewed changes

src/Symfony/Component/Console/Style/SymfonyStyle.php

		publicfunctiontable(array$headers,array$rows)
		{
		$headers =array_map(function ($value) {returnsprintf('<info>%s</>',$value); },$headers);
		array_walk_recursive($headers,function (&$value) {

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

recursive required? Then should we add a test case which would trigger this recursive part?

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not really recusive, but it can be one/two-dimensional array which is already covered bytest

Copy link

Member

nicolas-grekas commentedApr 19, 2016

👍

Copy link

Member

fabpot commentedApr 20, 2016

Thank you@aitboudad.

fabpot merged commit43cc93c intosymfony:2.7

Apr 20, 2016

fabpot added a commit that referenced this pull request

Apr 20, 2016

bug#18581[Console] [TableHelper] make it work with SymfonyStyle. (a…

2f0b8f8

…itboudad)This PR was merged into the 2.7 branch.Discussion----------[Console] [TableHelper] make it work with SymfonyStyle.| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | no| Fixed tickets |#18573| License       | MIT| Doc PR        | ~Commits-------43cc93c [Console] [TableHelper] make it work with SymfonyStyle.

aitboudad deleted the issue_18573 branch

April 20, 2016 09:27

Copy link

Contributor

ro0NL commentedApr 24, 2016•
edited
Loading

Question.. would aTable::set<Cell|Header|Row>Format() be nice to do thesprintf thingy in a standardized way? Imho this feels a bit like a workaround... something you have to repeat in each style implementation (and sure dont forget it ;-)).