Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fixed a redundant check in DefaultValueResolver#18575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Koc commentedApr 18, 2016
Heh, you answered on my question here#18308 (comment) |
linaori commentedApr 18, 2016
@Koc correct, back when I answered it, the sequences weren't that robust. Now that the So your comment was indeed correct, but ahead of time 👍 |
fabpot commentedApr 28, 2016
Thank you@iltar. |
This PR was merged into the 3.1-dev branch.Discussion----------Fixed a redundant check in DefaultValueResolver| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | ~| License | MIT| Doc PR | ~In#18308 I have introduced a `DefaultValueResolver`. When writing documentation, I was planning on adding the code as an example and I noticed it did a check in the request attributes. A default value value should always be injected, whether the request has it or not. In case the request _does_ have the value, it would've already been added and thus never reach the default resolver.Thus as this is never called in the default and configured flows and should not change the default value behavior, I'm removing this.Commits-------e54c1a6 Fixed a redundant check in DefaultValueResolver
In#18308 I have introduced a
DefaultValueResolver. When writing documentation, I was planning on adding the code as an example and I noticed it did a check in the request attributes. A default value value should always be injected, whether the request has it or not. In case the requestdoes have the value, it would've already been added and thus never reach the default resolver.Thus as this is never called in the default and configured flows and should not change the default value behavior, I'm removing this.