NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Filesystem] do not use unlink for directories#18516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

xabbuh wants to merge1 commit intosymfony:masterfromxabbuh:issue-18512

Closed

[Filesystem] do not use unlink for directories#18516

xabbuh wants to merge1 commit intosymfony:masterfromxabbuh:issue-18512

Conversation

Copy link

Member

xabbuh commentedApr 12, 2016

Q	A
Branch?	to be merged into 2.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?
Fixed tickets	#18512
License	MIT
Doc PR

carsonbot added the Status: Needs Review label

Apr 12, 2016

javiereguiluz added Bug Filesystem labels

Apr 12, 2016

xabbuh force-pushed theissue-18512 branch fromf35d563 to4e017d6Compare

April 12, 2016 09:26

Copy link

Member

nicolas-grekas commentedApr 12, 2016

#18515 should do it now

xabbuh force-pushed theissue-18512 branch 4 times, most recently from4de3efc to0bf5d83Compare

April 12, 2016 10:39

fixed error handling

dc228b8

xabbuh force-pushed theissue-18512 branch from0bf5d83 todc228b8Compare

April 12, 2016 10:45

Copy link

MemberAuthor

The failure seems to be related to the changes from#18272 (only the builds for themaster branch export theSYMFONY_PHPUNIT_OVERLOAD that's also the reason why the builds didn't fail on my fork as I used a separate branch for testing) when being used with PHPUnit 4.8 (PHP 5.5 is the only job not using PHPUnit 5). Note that I disabled exporting the variable which made the bridge register more stuff. Though I am currently not sure how to fix this best (but we for sure don't seem to have to update the Filesystem component).