Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[BUG] Delete class 'control-group' in bootstrap 3#18507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Toelath commentedApr 11, 2016
| Q | A |
|---|---|
| Branch? | 3.0 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18506 |
| License | MIT |
| Doc PR | any |
xabbuh commentedApr 14, 2016
I do not think that we can merge this as someone might already rely on the class being present in their own code. |
fabpot commentedApr 28, 2016
Do we really need to keep BC here? This is a Bootstrap theme and the class does not exist. |
Toelath commentedMay 1, 2016
This class does not exist in Bootstrap 3. More, this causes problems to display because this is not the default use of framework. The answers are either the deletion of the class in HTML or add CSS to correct buttons display. |
fabpot commentedMay 1, 2016
👍 for merge |
fabpot commentedMay 13, 2016
Thank you@Toelath. |
…e Degeeter)This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes#18507).Discussion----------[BUG] Delete class 'control-group' in bootstrap 3| Q | A| ------------- | ---| Branch? | 3.0| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#18506| License | MIT| Doc PR | anyCommits-------99f61d6 [BUG] Delete class 'control-group' in bootstrap 3