Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] anonymous services are always private#18491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedApr 9, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| $id =sprintf('%s_%d',hash('sha256',$file), ++$count); | ||
| $node->setAttribute('id',$id); | ||
| if ($services =$this->getChildren($node,'service')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This doesn't seem like it made much sense (was introduced in#10619).
HeahDude commentedApr 9, 2016
Thanks! It's been an hour since I'm trying to understand what's wrong with this :) This change you mention might be useless after9802a41. |
nicolas-grekas commentedApr 12, 2016
👍 |
nicolas-grekas commentedApr 12, 2016
Thank you@xabbuh. |
…e (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[DependencyInjection] anonymous services are always private| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------0a469a4 anonymous services are always private
DHager commentedMay 4, 2016
Reporting a BC break with#18703, although perhaps you could argue that our application had a long-standing bug that was simply revealed. 😕 |