Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Deprecate SerializerAwareEncoder#18483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
JhonnyL commentedApr 8, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| * @author Kévin Dunglas <dunglas@gmail.com> | ||
| */ | ||
| class XmlEncoderextends SerializerAwareEncoderimplements EncoderInterface, DecoderInterface, NormalizationAwareInterface | ||
| class XmlEncoderimplements EncoderInterface, DecoderInterface, NormalizationAwareInterface, SerializerAwareInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a BC break (in case someone type-hinted withSerializerAwareEncoder).
a6c3cf8 to2d09076CompareJhonnyL commentedApr 21, 2016
@xabbuh I reverted the changes to XmlEncoder. |
| * | ||
| * @author Jordi Boggiano <j.boggiano@seld.be> | ||
| * | ||
| * @deprecated since version 3.1, to be removed in 4.0. Use the SerializerAwareTrait instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the deprecation warning must be triggered too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
btw, this will be 3.2, not 3.1, as we are already feature-frozen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
But that would trigger a deprecation warning whenever XmlEncoder is used, with no option to fix it.
I will update to 3.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@stof Isn't the docblock annotation enough as the rest is handled by the debug class loader?
67c4c3b toaf57467CompareGuilhemN commentedJun 7, 2016
LGTM 👍 |
xabbuh commentedJun 8, 2016
👍 |
fabpot commentedJun 8, 2016
Thank you@JhonnyL. |
This PR was merged into the 3.2-dev branch.Discussion----------[Serializer] Deprecate SerializerAwareEncoder| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------af57467 [Serializer] Deprecate SerializerAwareEncoder