NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form] Remove unnecessary option assignment#18456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Tobion merged 1 commit intosymfony:2.3fromsergeyfedotov:remove_unnecessary_option_assignment

Apr 6, 2016

Merged

[Form] Remove unnecessary option assignment#18456

Tobion merged 1 commit intosymfony:2.3fromsergeyfedotov:remove_unnecessary_option_assignment

Apr 6, 2016

Conversation

Copy link

Contributor

sergeyfedotov commentedApr 5, 2016

Q	A
Branch?	2.3
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

Option assignment is not required because the prototype inherits this option from the parent form via standard inheritance mechanism.

Related pull requests:#16959,#18317

Remove unnecessary option assignment

da8a197

Copy link

Contributor

HeahDude commentedApr 5, 2016

👍 Good catch, I failed to understand when you first proposed it in#18317.

Status: Reviewed

carsonbot added the Status: Reviewed label

Apr 5, 2016

javiereguiluz added the Form label

Apr 6, 2016

Copy link

Contributor

Tobion commentedApr 6, 2016

This basically reverts#16959. So the issue that it fixed (#15544) was not actually broken as the test still passes?

Copy link

ContributorAuthor

sergeyfedotov commentedApr 6, 2016

#18317 resolves the issue#15544 by the new way. Tests that have been introduced in the#16959 still pass.

Copy link

Member

xabbuh commentedApr 6, 2016

👍

Copy link

Contributor

Tobion commentedApr 6, 2016

Thank you@sergeyfedotov.

Tobion merged commitda8a197 intosymfony:2.3

Apr 6, 2016

Tobion added a commit that referenced this pull request

Apr 6, 2016

minor#18456[Form] Remove unnecessary option assignment (sergeyfedotov)

e251e36

This PR was merged into the 2.3 branch.Discussion----------[Form] Remove unnecessary option assignment| Q             | A| ------------- | ---| Branch?       | 2.3| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Option assignment is not required because the prototype inherits this option from the parent form via standard inheritance mechanism.Related pull requests:#16959,#18317Commits-------da8a197 Remove unnecessary option assignment