Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
changelogs missing features after #17589#18412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
HeahDude commentedApr 2, 2016
| Q | A |
|---|---|
| Branch? | master |
| License | MIT |
HeahDude commentedApr 2, 2016
I added a second commit with cs fixes, as it goes in master it should not be a pain to merge older branches as it would to merge it upward, right ? |
0f1de44 toda3e8b0CompareHeahDude commentedApr 3, 2016
Updated here, I've forgotten one method... Is the second commit needed ? I can remove it. Thanks |
nicolas-grekas commentedApr 3, 2016
@HeahDude when a CS fix could be applied on lower branches, it must be applied there. |
HeahDude commentedApr 3, 2016
@nicolas-grekas thanks, since this fixes are needed for a long time I thought it did not happens because it would have been a pain to merge upward from lower branches. I revert it right away :) |
da3e8b0 to26da79cCompareHeahDude commentedApr 3, 2016
Ready! |
| 3.1.0 | ||
| ----- | ||
| * added shortcuts for redirected and forwarded request's profiles in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I am not sure if everyone will understand what is meant with "shortcut".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Right! What about "links" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What about "added information about redirected and forwared requests to the profiler"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Simple and efficient! Thanks :)
26da79c to724fd3bCompareHeahDude commentedApr 6, 2016
@xabbuh fixed! Thanks. |
xabbuh commentedApr 6, 2016
👍 |
stof commentedApr 7, 2016
@HeahDude actually, applying a CS fix only to the latest version would make any future upward merge painful due to conflicts. |
HeahDude commentedApr 7, 2016
Good to know! |
fabpot commentedApr 7, 2016
Thank you@HeahDude. |