Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Debug] Fix case sensitivity checks#18352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedMar 29, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18344 |
| License | MIT |
| Doc PR | - |
stof commentedMar 29, 2016
Looks like deps=high needs some fixing. regarding this PR, this looks good to me. 👍 |
alexchip64 commentedMar 30, 2016
With this fix, in Windows system, $caseCheck is set to "0", whereas it should be set to "1" (filesystem is NOT case sensitive) as in previous versions. |
nicolas-grekas commentedMar 30, 2016
@alexchip64 can you detail why it ends up being set to zero in your case? |
alexchip64 commentedMar 30, 2016
Because, in my case, the situation of the checking is as follow: $file = C:\Users\cipriano\Documents\NetBeansProjects\zoe\vendor\symfony\symfony\src\Symfony\Component\Debug\DebugClassLoader.php $fileTest = C:\USERS\CIPRIANO\DOCUMENTS\NETBEANSPROJECTS\ZOE\VENDOR\SYMFONY\SYMFONY\SRC\SYMFONY\COMPONENT\DEBUG\DEBUGCLASSLOADER.PHP but realpath($fileTest) = C:\Users\cipriano\DOCUMENTS\NETBEANSPROJECTS\zoe\vendor\symfony\symfony\src\Symfony\Component\Debug\DebugClassLoader.php so the check |
nicolas-grekas commentedMar 30, 2016
does it work better if you use strtolower instead of strtoupper? |
alexchip64 commentedMar 30, 2016
I've done it, it but final result does not change:
but
|
nicolas-grekas commentedMar 30, 2016
strange... this means it couldn't work previously and caseCheck ended up being 2, not 1, isn't it? |
alexchip64 commentedMar 30, 2016
Version 2.8.4 does not work in Windows as I indicated in my#18344, because final value is 2 and Symfony hangs.
|
nicolas-grekas commentedMar 30, 2016
@alexchip64 PR updated, can you please check the new patch? |
alexchip64 commentedMar 30, 2016
Nothing changes.
and
so the checking: returns false |
nicolas-grekas commentedMar 30, 2016
My bad, it should be |
alexchip64 commentedMar 30, 2016
Now it is ok. At least it appears ok for Windows systems. |
fabpot commentedMar 30, 2016
Thank you@nicolas-grekas. |
This PR was merged into the 2.7 branch.Discussion----------[Debug] Fix case sensitivity checks| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets |#18344| License | MIT| Doc PR | -Commits-------7336177 [Debug] Fix case sensitivity checks