Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[phpunit] disable prophecy#18304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedMar 25, 2016
Isn't it fixed already ? A bunch of PRs related to it have been merged already |
stof commentedMar 25, 2016
you forgot to update the cache id |
phpunit Outdated
| chdir("phpunit-$PHPUNIT_VERSION"); | ||
| passthru("$COMPOSER remove --no-update symfony/yaml"); | ||
| passthru("$COMPOSER remove --no-update phpspec/prophecy"); | ||
| passthru("$COMPOSER require --no-update phpunit/phpunit-mock-objects\"3.1.1\""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
3.1.1 is not compatible with PHP 5.3 to 5.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change should not be done for PHPUnit 4.8, as it depends onphpunit/phpunit-mock-objects ~2.3
stof commentedMar 25, 2016
@nicolas-grekas can you also try to debug failures inhttps://travis-ci.org/symfony/symfony/jobs/118326801#L1867 ? This looks weird as the PropertyAccess 2.3.0 component is installed, and it contains this class. This makes me think there might be a corruption of the installation in our Travis setup |
xabbuh commentedMar 25, 2016
@stof I fixed a lot of mocks Sebastian Bergmann reported for the |
nicolas-grekas commentedMar 25, 2016
nicolas-grekas commentedMar 25, 2016
Rebased on top of#18306 |
nicolas-grekas commentedMar 25, 2016
No need to change the cache id btw here |
xabbuh commentedMar 25, 2016
@nicolas-grekas What is the point in adding this but not updating the cache id? This way it doesn't have any affect, does it (seems I do miss something)? |
nicolas-grekas commentedMar 25, 2016
The real cache-id is the md5 of the phpunit file itself. The cache id in the comment is just a way to change this md5 without changing actual code. |
dunglas commentedMar 25, 2016
A PR to fix Prophecy is ready:phpspec/prophecy#264 |
nicolas-grekas commentedMar 27, 2016
@dunglas we don't use prophecy in Symfony's test suite. Should we allow using it? Until now, we've asked people submitting prophecy tests to rewrite them to regular phpunit mock tests. If we stick to this policy, then we should merge this PR. If we should allow prophecy, then not of course. |
fabpot commentedMar 27, 2016
IIUC, prophecy is not a direct dep, but installed but phpunit, right? In any case, we are not using prophecy in Symfony, so let's drop it. |
fabpot commentedMar 27, 2016
And if we start using it, we would then be able to add it explicitly. |
fabpot commentedMar 27, 2016
Thank you@nicolas-grekas. |
This PR was merged into the 2.3 branch.Discussion----------[phpunit] disable prophecy| Q | A| ------------- | ---| Branch? | 2.3| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Both Prophecy and Symfony require some phpdocumentor dependencies, but incompatible versions.Since we don't use Prophecy, let's disable it.phpunit-mock-objects is forced to v3.1.1 until we fix our test suite (seesebastianbergmann/phpunit-mock-objects#299).Commits-------ae9bae7 [phpunit] disable prophecy
dunglas commentedMar 27, 2016
@nicolas-grekas it was just a side note. |
Both Prophecy and Symfony require some phpdocumentor dependencies, but incompatible versions.
Since we don't use Prophecy, let's disable it.
phpunit-mock-objects is forced to v3.1.1 until we fix our test suite (seesebastianbergmann/phpunit-mock-objects#299).