Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translation] deprecate the backup feature#18290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedMar 24, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #16912 (comment) |
| License | MIT |
| Doc PR |
javiereguiluz commentedMar 29, 2016
@xabbuh@aitboudad what if we remove this backup feature altogether for the Translation component? My feel is that we're trying to do "too much" here. In Symfony we do more "dangerous" things (e.g. the SensioGeneratorBundle) without providing a backup feature. |
fabpot commentedMar 29, 2016
I agree with@javiereguiluz |
aitboudad commentedMar 29, 2016
I agree too. |
stof commentedMar 29, 2016
I agree too. I'm always disabling this backup, as git already gives me a way to get the old file if something goes wrong, and backup files only lead to mistakes in such cases |
xabbuh commentedMar 29, 2016
I am not too familiar with the Translation component internals. But if you all agree on this, I will revert the new interface and instead deprecate the |
aitboudad commentedMar 29, 2016
@xabbuh I think so and deprecate backup for the |
fabpot commentedMar 29, 2016
👍 for deprecation |
4fde2f1 to6c3ddf1Comparexabbuh commentedMar 31, 2016
I added deprecation trigger for the backup feature. I couldn't deprecate the |
fabpot commentedApr 1, 2016
Thank you@xabbuh. |
This PR was merged into the 3.1-dev branch.Discussion----------[Translation] deprecate the backup feature| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#16912 (comment)| License | MIT| Doc PR |Commits-------6c3ddf1 [Translation] deprecate the backup feature
…when using "--no-backup" (liarco)This PR was squashed before being merged into the 5.1 branch.Discussion----------[FrameworkBundle] Fixing TranslationUpdateCommand failure when using "--no-backup"| Q | A| ------------- | ---| Branch? | 5.1| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |[5.0.0](https://github.com/symfony/symfony/blob/5.0/src/Symfony/Component/Translation/CHANGELOG.md#500) removed `TranslationWriter::disableBackup()` but `TranslationUpdateCommand` still has `--no-backup` flag. Using that flag throws an error so I think that removing it without deprecation may be the right choice.Thrown error:```In TranslationUpdateCommand.php line 287: Attempted to call an undefined method named "disableBackup" of class "Symfony\Component\Translation\Writer\TranslationWriter".```Further references to the topic: -#18290 (comment) -#25860Commits-------ef24b10 [FrameworkBundle] Fixing TranslationUpdateCommand failure when using "--no-backup"