Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] Fix BC break introduced in #14403#18275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.8fromHeahDude:fix-form-read_only
Mar 27, 2016

Conversation

@HeahDude
Copy link
Contributor

QA
Branch?2.8
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PR-

@HeahDude
Copy link
ContributorAuthor

@HeahDude
Copy link
ContributorAuthor

Note to merger: to revert in 3.0

@xabbuh
Copy link
Member

Why is the order of the attributes important? Imo you should not rely on it.

@HeahDude
Copy link
ContributorAuthor

@xabbuh we don't have the choice IMHO.

The component themes need to print the value independently fromattr so they can be overridden with:

{%setread_only=true %}{{block('parent_block') }}

@mnapoli
Copy link
Contributor

👍 however I think the tests need to be reverted too to ensure that we are fixing the problem (see#14403 (comment))

@HeahDude
Copy link
ContributorAuthor

@mnapoli Thanks for the review, the tests are already reverted (otherwise they would fail).

Failures are unrelated.

@xabbuh
Copy link
Member

You will now need to update the lowest version of the Form component required by the FrameworkBundle to^2.8.4.

@HeahDude
Copy link
ContributorAuthor

@xabbuh so it should be done in a second commit since this one is supposed to be reverted in 3.0, right ?

@xabbuh
Copy link
Member

Not necessarily if I don't misunderstand you. We need to revert all the changes here in the3.0 branch, don't we?

@HeahDude
Copy link
ContributorAuthor

Yes we do.

@HeahDude
Copy link
ContributorAuthor

Thanks@xabbuh tests are all green now (excepted appveyor being unusually long).

@HeahDude
Copy link
ContributorAuthor

It seems appveyor has bugged, why does it still try to install icu v51 ?

@xabbuh
Copy link
Member

👍

Status: Reviewed

@HeahDude
Copy link
ContributorAuthor

@xabbuh Do I need to upgrade thecomposer.json ofTwigBridge too ?

@xabbuh
Copy link
Member

@HeahDude Usually you would have to do that. But this time that's not necessary as this was apparently done in another pull request before:https://github.com/symfony/symfony/blob/2.8/src/Symfony/Bridge/Twig/composer.json#L25

@HeahDude
Copy link
ContributorAuthor

@xabbuh Thanks for your leading :)

@fabpot
Copy link
Member

Thank you@HeahDude.

@fabpotfabpot merged commit5f48c6a intosymfony:2.8Mar 27, 2016
fabpot added a commit that referenced this pull requestMar 27, 2016
This PR was merged into the 2.8 branch.Discussion----------[Form] Fix BC break introduced in#14403| Q             | A| ------------- | ---| Branch?       | 2.8| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | -Commits-------5f48c6a [Form] Fix BC break introduced in#14403
fabpot added a commit that referenced this pull requestMar 27, 2016
@HeahDudeHeahDude deleted the fix-form-read_only branchMarch 27, 2016 12:14
@mnapoli
Copy link
Contributor

Thanks@HeahDude for the fix!

@HeahDude
Copy link
ContributorAuthor

@mnapoli Thanks for reporting this issue :)

This was referencedMar 27, 2016
fabpot added a commit that referenced this pull requestMar 27, 2016
* 3.0:  bumped Symfony version to 2.8.5  updated VERSION for 2.8.4  updated CHANGELOG for 2.8.4  Revert "bug#18275 [Form] Fix BC break introduced in#14403 (HeahDude)"  improved comment  [FileSystem] Add support for Google App Engine.  [2.8] fix mocks  bumped Symfony version to 2.7.12  [Form] Fix BC break introduced in#14403  updated VERSION for 2.7.11  updated CHANGELOG for 2.7.11  [Request] Fix support of custom mime types with parameters  fix mocks  fix mocks  [Validator] do not treat payload as callback
@fabpotfabpot mentioned this pull requestMar 30, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@HeahDude@xabbuh@mnapoli@fabpot@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp