Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add tests#18272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:2.7fromnicolas-grekas:phpunit-test
Mar 23, 2016

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#18222
LicenseMIT
Doc PR-

@nicolas-grekasnicolas-grekas changed the title[Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, …[Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add testsMar 23, 2016
@nicolas-grekasnicolas-grekas merged commit4ea9548 intosymfony:2.7Mar 23, 2016
nicolas-grekas added a commit that referenced this pull requestMar 23, 2016
…weak mode, add tests (nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add tests| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#18222| License       | MIT| Doc PR        | -Commits-------4ea9548 [Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add tests
@nicolas-grekasnicolas-grekas deleted the phpunit-test branchMarch 23, 2016 13:17
This was referencedMar 25, 2016
@cjunge-work
Copy link

Since the 2.8.4 release, I am getting
Warning: Ambiguous class resolution, "Symfony\Bridge\PhpUnit\TextUI\TestRunner" was found in both "/var/www/api-admin/vendor/symfony/phpunit-bridge/TextUI/TestRunner.php" and "/var/www/api-admin/vendor/symfony/symfony/src/Symfony/Bridge/PhpUnit/TextUI/TestRunner.php", the first will be used.
Warning: Ambiguous class resolution, "Symfony\Bridge\PhpUnit\TextUI\Command" was found in both "/var/www/api-admin/vendor/symfony/phpunit-bridge/TextUI/Command.php" and "/var/www/api-admin/vendor/symfony/symfony/src/Symfony/Bridge/PhpUnit/TextUI/Command.php", the first will be used.
Warning: Ambiguous class resolution, "Symfony\Bridge\PhpUnit\DeprecationErrorHandler" was found in both "/var/www/api-admin/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php" and "/var/www/api-admin/vendor/symfony/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php", the first will be used.
Warning: Ambiguous class resolution, "Symfony\Bridge\PhpUnit\ClockMock" was found in both "/var/www/api-admin/vendor/symfony/phpunit-bridge/ClockMock.php" and "/var/www/api-admin/vendor/symfony/symfony/src/Symfony/Bridge/PhpUnit/ClockMock.php", the first will be used.
Warning: Ambiguous class resolution, "Symfony\Bridge\PhpUnit\SymfonyTestsListener" was found in both "/var/www/api-admin/vendor/symfony/phpunit-bridge/SymfonyTestsListener.php" and "/var/www/api-admin/vendor/symfony/symfony/src/Symfony/Bridge/PhpUnit/SymfonyTestsListener.php", the first will be used.

I assume it's related to this issue?

Based on the message shown it appears the old classes will be used, not the bug fix.

fabpot added a commit that referenced this pull requestApr 1, 2016
…colas-grekas)This PR was merged into the 2.7 branch.Discussion----------Exclude Bridge\PhpUnit from composer.json by default| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#18381,#18272| License       | MIT| Doc PR        | -Commits-------4f90495 Exclude Bridge\PhpUnit from composer.json by default
greg0ire added a commit to greg0ire/symfony that referenced this pull requestSep 18, 2018
This would fail if we were using strict mode with php 7, because true isonly a valid argument for php < 5.3.6.This was changed from PHP_VERSION_ID >= 50400 ?DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true insymfony#18272, but I do not understand why it was simlified, nor whyDEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
greg0ire added a commit to greg0ire/symfony that referenced this pull requestSep 18, 2018
This would fail if we were using strict mode with php 7, because true isonly a valid argument for php < 5.3.6.This was changed from PHP_VERSION_ID >= 50400 ?DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true insymfony#18272, but I do not understand why it was simlified, nor whyDEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
greg0ire added a commit to greg0ire/symfony that referenced this pull requestSep 18, 2018
This would fail if we were using strict mode with php 7, because true isonly a valid argument for php < 5.3.6.This was changed from PHP_VERSION_ID >= 50400 ?DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true insymfony#18272, but I do not understand why it was simlified, nor whyDEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
greg0ire added a commit to greg0ire/symfony that referenced this pull requestSep 19, 2018
This would fail if we were using strict mode with php 7, because true isonly a valid argument for php < 5.3.6.This was changed from PHP_VERSION_ID >= 50400 ?DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true insymfony#18272, but I do not understand why it was simplified, nor whyDEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
nicolas-grekas added a commit that referenced this pull requestSep 20, 2018
… (greg0ire)This PR was merged into the 2.8 branch.Discussion----------[PhpUnitBridge] Provide debug_backtrace with proper argsThis would fail if we were using strict mode with php 7, because true isonly a valid argument for php < 5.3.6.This was changed from PHP_VERSION_ID >= 50400 ?DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in#18272, but I do not understand why it was simlified, nor whyDEBUG_BACKTRACE_IGNORE_ARGS was there at that time.| Q             | A| ------------- | ---| Branch?       | 2.8| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aNot sure if this qualifies as a bugfix. If not, should I simplify the ternary and target master? My fear is that having the code diverge too much will make it harder to merge subsequent PRs. I know this looks small, but I'm kind of preparing a big PR on the bridge and I'd rather have it smaller and easier to understand by moving everything I can with small patches like this one.Commits-------0d826ae Provide debug_backtrace with proper args
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@cjunge-work@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp