Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Intl] Fix invalid numeric literal on PHP 7#18216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.3fromnicolas-grekas:fix-18082
Mar 18, 2016

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?2.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

Work aroundtrue === is_float(-9223372036854775808).

@javiereguiluzjaviereguiluz changed the title[NumberFormatter] Fix invalid numeric literal on PHP 7[Intl] Fix invalid numeric literal on PHP 7Mar 17, 2016
* The maximumvalues of the integer type in 32 bit platforms.
* The maximumvalue of the integer type in 32 bit platforms.
*
* @var array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

needs update

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fixed thanks

@Tobion
Copy link
Contributor

While you are at it, the@return onparse is wrong as well. It must be@return int|float|false

When merging in 3.0 the@see https://bugs.php.net/bug.php?id=59597 Bug #59597 should be removed as the bug is not relevant in the 3.x PHP versions. Maybe it's easiest the remove this@see directly here and thus merged upwards as the bug is already referenced in the code.

@nicolas-grekas
Copy link
MemberAuthor

@Tobion updated

@Tobion
Copy link
Contributor

👍

Status: Reviewed

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit999c0a5 intosymfony:2.3Mar 18, 2016
fabpot added a commit that referenced this pull requestMar 18, 2016
This PR was merged into the 2.3 branch.Discussion----------[Intl] Fix invalid numeric literal on PHP 7| Q             | A| ------------- | ---| Branch?       | 2.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Work around `true === is_float(-9223372036854775808)`.Commits-------999c0a5 [NumberFormatter] Fix invalid numeric literal on PHP 7
@nicolas-grekasnicolas-grekas deleted the fix-18082 branchMarch 18, 2016 10:21
This was referencedMar 25, 2016
@fabpotfabpot mentioned this pull requestApr 29, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@Tobion@fabpot@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp