Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][2.8] Add tests for the Controller class#18206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedMar 17, 2016
Missing dependency for Twig in the FrameworkBundle's |
dunglas commentedMar 17, 2016
@xabbuh thanks, fixed. |
dunglas commentedMar 17, 2016
AppVeyor error not related. |
composer.json Outdated
| "egulias/email-validator":"~1.2", | ||
| "phpdocumentor/reflection":"^1.0.7" | ||
| "phpdocumentor/reflection":"^1.0.7", | ||
| "twig/twig":"~1.23|~2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we already have Twig as a regular requirement. Having it in both section is bad as it can create weird behaviors in Composer (unlikely here for ow as the constraint is the same, but they may likely get out of sync)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My bad my first intent was to update the FrameworkBundle one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So, this change should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
fabpot commentedMar 21, 2016
Thank you@dunglas. |
…s (dunglas)This PR was squashed before being merged into the 2.8 branch (closes#18206).Discussion----------[FrameworkBundle][2.8] Add tests for the Controller class| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aBackport tests of#18193 to the `abstract` Controller.Commits-------5ee9f93 [FrameworkBundle][2.8] Add tests for the Controller class
Backport tests of#18193 to the
abstractController.