Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfiler] Sidebar button padding#18087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.8fromrvanlaak:patch-7
Mar 10, 2016
Merged

Conversation

@rvanlaak
Copy link
Contributor

QA
Branch2.8
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Before

image

After

image

@javiereguiluz
Copy link
Member

I can't reproduce this issue, but I obviously give it a 👍

@rvanlaak I have another question: theSearch button is slightly taller than the other buttons (I guess because of the icon). Could you please check if this can be solved in a simple way to include the fix in this pull request too? Thanks!

@rvanlaak
Copy link
ContributorAuthor

@javiereguiluz you are right about the svg, it actually was the reason for the behavior as seen in the screenshots. Thesvg icons should always haveheight andwidth. Fixed it for another occurrence too.

@fabpot
Copy link
Member

Thank you@rvanlaak.

@fabpotfabpot merged commit0862334 intosymfony:2.8Mar 10, 2016
fabpot added a commit that referenced this pull requestMar 10, 2016
This PR was merged into the 2.8 branch.Discussion----------[WebProfiler] Sidebar button padding| Q             | A| ------------- | ---| Branch        | 2.8| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |**Before**![image](https://cloud.githubusercontent.com/assets/2707563/13665247/bb57b9c8-e6ab-11e5-8347-d26239bab06f.png)**After**![image](https://cloud.githubusercontent.com/assets/2707563/13665273/dfbbf860-e6ab-11e5-959c-2a56c6e1b7e5.png)Commits-------0862334 [WebProfiler] Sidebar button padding
@rvanlaakrvanlaak deleted the patch-7 branchMarch 23, 2016 19:47
This was referencedMar 27, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rvanlaak@javiereguiluz@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp